From owner-freebsd-acpi@FreeBSD.ORG Wed May 26 02:53:53 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5516716A4CE for ; Wed, 26 May 2004 02:53:53 -0700 (PDT) Received: from moutvdomng.kundenserver.de (moutvdom.kundenserver.de [212.227.126.249]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5FEC43D41 for ; Wed, 26 May 2004 02:53:52 -0700 (PDT) (envelope-from liamfoy@sepulcrum.org) Received: from [212.227.126.224] (helo=mrvdomng.kundenserver.de) by moutvdomng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BSv5z-00036j-00; Wed, 26 May 2004 11:53:11 +0200 Received: from [217.42.210.193] (helo=liamfoy.ath.cx) by mrvdomng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BSv5z-0000I4-00; Wed, 26 May 2004 11:53:11 +0200 Date: Wed, 26 May 2004 10:52:11 +0100 From: "Liam J. Foy" To: "Grover, Andrew" Message-Id: <20040526105211.3b6667ac.liamfoy@sepulcrum.org> In-Reply-To: References: X-Mailer: Sylpheed version 0.9.10 (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: freebsd-acpi@freebsd.org Subject: Re: APM Patch - review X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2004 09:53:53 -0000 On Tue, 25 May 2004 15:43:55 -0700 "Grover, Andrew" wrote: > Valid values for remaining battery life are 0xFF, and 0-100. > > -1, 255 and 0xFF are the SAME when looking at an 8 bit value. Since this > 8 bit value was sign-extended to 32 bits to go into ai_batt_time, if it > was 0xFF, it is now 0xFFFFFFFF, and you will never see 0x000000FF. > > I will email you the APM spec privately (it's big). Please take a look > at page 42 especially. > > Regards -- Andy Ah I see. This would mean alot of the apm code in function print_all_info is not needed. Correct? That manual is great Andy! Thanks:)! >