From owner-freebsd-audit Mon Jun 25 22: 8:30 2001 Delivered-To: freebsd-audit@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id 628FD37B401 for ; Mon, 25 Jun 2001 22:08:25 -0700 (PDT) (envelope-from mike@coffee.q9media.com) Received: (from mike@localhost) by coffee.q9media.com (8.11.2/8.11.2) id f5Q5LR593219; Tue, 26 Jun 2001 01:21:27 -0400 (EDT) (envelope-from mike) Date: Tue, 26 Jun 2001 01:21:27 -0400 (EDT) Message-Id: <200106260521.f5Q5LR593219@coffee.q9media.com> To: audit@FreeBSD.org From: Mike Barcroft Subject: src/usr.sbin/burncd patch Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I would appreciate it if someone would review and commit the patch at the end of this message. Also available at: http://testbed.q9media.net/freebsd/burncd.20010626.patch I wasn't able to set WARNS?=2 because cleanup() doesn't use the integer in it's prototype. Does anyone have any suggestions to solve this? Best regards, Mike Barcroft ----------------------------------------------------------------------- o Clean up compile-time warnings. Index: burncd/burncd.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/burncd/burncd.c,v retrieving revision 1.13 diff -u -r1.13 burncd.c --- burncd/burncd.c 2001/05/30 08:13:39 1.13 +++ burncd/burncd.c 2001/06/26 04:56:24 @@ -56,7 +56,7 @@ { int ch, arg, addr; int eject=0, list=0, multi=0, preemp=0, speed=1, test_write=0; - char *devname = "/dev/acd0c", *prog_name; + const char *dev_name = "/dev/acd0c", *prog_name; int block_size = 0; prog_name = argv[0]; @@ -67,7 +67,7 @@ break; case 'f': - devname = optarg; + dev_name = optarg; break; case 'l': @@ -106,8 +106,8 @@ if (argc == 0) usage(prog_name); - if ((fd = open(devname, O_RDWR, 0)) < 0) - err(EX_NOINPUT, "open(%s)", devname); + if ((fd = open(dev_name, O_RDWR, 0)) < 0) + err(EX_NOINPUT, "open(%s)", dev_name); if (ioctl(fd, CDRIOCWRITESPEED, &speed) < 0) err(EX_IOERR, "ioctl(CDRIOCWRITESPEED)"); @@ -134,7 +134,7 @@ err(EX_IOERR, "ioctl(CDIOREADTOCENTRY)"); if (ioctl(fd, CDRIOCNEXTWRITEABLEADDR, &addr) < 0) err(EX_IOERR, "ioctl(CDRIOCNEXTWRITEABLEADDR)"); - fprintf(stderr, "%d, %d\n", + fprintf(stderr, "%lu, %d\n", ntohl(entry.entry.addr.lba), addr); break; @@ -207,7 +207,7 @@ while (fgets(file_buf, sizeof(file_buf), fp) != NULL) { if (*file_buf == '#' || *file_buf == '\n') continue; - if (eol = strchr(file_buf, '\n')) + if ((eol = strchr(file_buf, '\n')) != NULL) *eol = NULL; write_file(file_buf, block_size); } @@ -252,7 +252,7 @@ { int addr, count, file, filesize, size; char buf[2352*BLOCKS]; - struct stat stat; + struct stat filestat; static int cdopen, done_stdin, tot_size = 0; if (!strcmp(name, "-")) { @@ -278,9 +278,9 @@ if (ioctl(fd, CDRIOCNEXTWRITEABLEADDR, &addr) < 0) err(EX_IOERR, "ioctl(CDRIOCNEXTWRITEABLEADDR)"); - if (fstat(file, &stat) < 0) + if (fstat(file, &filestat) < 0) err(EX_IOERR, "fstat(%s)", name); - filesize = stat.st_size / 1024; + filesize = filestat.st_size / 1024; if (!quiet) { fprintf(stderr, "next writeable LBA %d\n", addr); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message