From owner-cvs-all  Wed Mar 28 12:51:25 2001
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id E1BFA37B718; Wed, 28 Mar 2001 12:51:19 -0800 (PST)
	(envelope-from jim@FreeBSD.org)
Received: (from jim@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f2SKpJq64500;
	Wed, 28 Mar 2001 12:51:19 -0800 (PST)
	(envelope-from jim)
Message-Id: <200103282051.f2SKpJq64500@freefall.freebsd.org>
From: Jim Mock <jim@FreeBSD.org>
Date: Wed, 28 Mar 2001 12:51:19 -0800 (PST)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: ports/mail/teapop/files patch-ab
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

jim         2001/03/28 12:51:19 PST

  Added files:
    mail/teapop/files    patch-ab 
  Log:
  Fix the following from the PR:
  
     First, teapop fails to authentificate user if he logs in without
     specifying his domain (pop_auth calls pop_string_find and tests its
     result against being NULL, while NULL is returned only upon malloc()
     failures. On empty domain logins pop_string_find returns empty
     string). This makes APOP login method to always fail as teapop
     erroneously interprets command APOP avn
     d41d8cd98f00b204e9800998ecf8427e as an attempt of login for user
     avn@d41d8cd98f00b204e9800998ecf8427e without supplying MD5 hash
     value. Instead, return value should be tested against being empty
     string, while positive test for NULL should cause pop3 server error
     message to be printed.
  
     Second, if configured with WITHOUT_APOP arguments to 'make install',
     teapop incorrectly handles QUIT command while in authentification
     state. It's because a part of switch statement became commented out
     and there will be no branch for return value from
     pop_wait_for_commands with command "QUIT" (it will return 3, not 4
     when configured without APOP).
  
  PR:		26181
  Submitted by:	Alexey V. Neyman <avn@any.ru>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message