Date: Tue, 9 Nov 2010 04:00:25 GMT From: Alexey Dokuchaev <danfe@nsu.ru> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/151626: [NEW PORT] databases/py-flask-sqlalchemy, add SQLAlchemy support to Flask Message-ID: <201011090400.oA940PMk035892@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/151626; it has been noted by GNATS. From: Alexey Dokuchaev <danfe@nsu.ru> To: bug-followup@FreeBSD.org, duchateau.olivier@gmail.com Cc: Subject: Re: ports/151626: [NEW PORT] databases/py-flask-sqlalchemy, add SQLAlchemy support to Flask Date: Tue, 9 Nov 2010 09:52:58 +0600 Nice work, could of minor nits: - Date created in Makefile header shold probably be lined up with port name (also, in here, official "Flask-SQLAlchemy" could be used as the port name since it's more descriptive) - Two spaces after PKGNAMEPREFIX=, space after DISTNAME= (should be tabs) - Missing another leading tab in the second line of RUN_DEPENDS= - Spaces after PYDISTUTILS_PKGNAME= and PYDISTUTILS_PKGVERSION= should be tabs - LICENSE could probably be placed after COMMENT, but that's more just a matter of personal taste - Tab after WWW: line in pkg-descr shoud be space
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011090400.oA940PMk035892>