From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Mar 16 01:40:11 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8F2316A4CE for ; Tue, 16 Mar 2004 01:40:10 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id CBB7943D46 for ; Tue, 16 Mar 2004 01:40:10 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i2G9eAbv072580 for ; Tue, 16 Mar 2004 01:40:10 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i2G9eA08072579; Tue, 16 Mar 2004 01:40:10 -0800 (PST) (envelope-from gnats) Date: Tue, 16 Mar 2004 01:40:10 -0800 (PST) Message-Id: <200403160940.i2G9eA08072579@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Oliver Eikemeier Subject: Re: ports/64317: Update of german/BBBike port X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Oliver Eikemeier List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2004 09:40:11 -0000 The following reply was made to PR ports/64317; it has been noted by GNATS. From: Oliver Eikemeier To: slaven@rezic.de Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/64317: Update of german/BBBike port Date: Tue, 16 Mar 2004 10:39:48 +0100 Slaven Rezic wrote: > 9:25 eserte@vran 297 (/tmp/BBBike): port test > ===> Validating port with portlint > FATAL: Makefile [12]: use a tab (not space) after a variable name > WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead. > WARN: Makefile: be sure to include language code "de-" in the module alias name. > WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples. > WARN: no CVS directories. Use -N to check a new port. > 1 fatal errors and 4 warnings found. > Error validating port > Exit 1 > > 9:26 eserte@vran 298 (/tmp/BBBike): portlint > WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead. > WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples. > 0 fatal errors and 2 warnings found. > > But: ("port test" seems to use -t internally) > > 9:26 eserte@vran 299 (/tmp/BBBike): portlint -t > FATAL: Makefile [12]: use a tab (not space) after a variable name > WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead. > WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples. > 1 fatal errors and 2 warnings found. > Exit 1 > > (which seems somewhat too nit-picky to me) This is fine, since we often use tools like grep or sed to work on the ports tree, so a little uniformity helps a lot here. You should fix the space issue, the one with install is a known problem, and specifying RUN_DEPENDS=${BUILD_DEPENDS} on perl ports is normally the right thing to do. > I used to use PERL_VERSION and PERL_ARCH, but this does not work with > the latest FreeBSD 5.2 builds. It seems to me that a change caused > PERL_ARCH to be something like "mach". BBBike does not install > compiled perl modules to site_perl, but into a private arch directory > with the machine name still included ("lib/i386-freebsd" on older > perls, "lib/5.8.x/i386-freebsd" on current perls). > > I do not think that many perl applications use the same installation > scheme, so an extra variable is not the right solution. PERL_VERSION and ARCH should do the trick. Besides, how about patching BBBike to behave properly? > Well, then I think it's best to generate pkg-plist from script. Maybe this is a good solution. OTOH the pkg-plist doesn't differ much, it should be easily done with a custom variable. I'm not trying to be extremly picky with your port here, but we have 10k+ ports in the tree, and we have to test them all when make inprovements to the ports tree infrastructure, so it is important that they share a common structure. Thanks Oliver