From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Oct 24 06:50:01 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E300B2A5 for ; Wed, 24 Oct 2012 06:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.FreeBSD.org [8.8.178.135]) by mx1.freebsd.org (Postfix) with ESMTP id CB6548FC12 for ; Wed, 24 Oct 2012 06:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9O6o1a6083969 for ; Wed, 24 Oct 2012 06:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9O6o1lr083946; Wed, 24 Oct 2012 06:50:01 GMT (envelope-from gnats) Date: Wed, 24 Oct 2012 06:50:01 GMT Message-Id: <201210240650.q9O6o1lr083946@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Sean Greven Subject: ports/171951: update port: security/fwknop FireWall KNock OPerator X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Sean Greven List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2012 06:50:02 -0000 The following reply was made to PR ports/171951; it has been noted by GNATS. From: Sean Greven To: Raphael Kubo da Costa , bug-followup@FreeBSD.org Cc: Subject: ports/171951: update port: security/fwknop FireWall KNock OPerator Date: Wed, 24 Oct 2012 08:41:28 +0200 (SAST) ------=_Part_11_25861043.1351060888249 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit I have re-submitted the .shar file as a pr via the web interface. It unfortunately doesn't cater for cc lines. I am attaching the new .shar file for reference Regards Sean ----- Original Message ----- From: "Raphael Kubo da Costa" To: "Sean Greven" Sent: Wednesday, October 24, 2012 12:20:35 AM Subject: Re: ports/171951: update port: security/fwknop FireWall KNock OPerator Sean Greven writes: > Hi there > > Thank you very much for the reply. > > I do need to apologise up front, I am not 100% up to scratch yet on > the port mechanism, I have used it for years, but some of the > mechanics allude me. So any criticism is welcome. I hope you don't > mind me asking a few questions. Sure, sorry for the delay on my side, and thanks for the effort :-) >> A few comments about the patch: >> >> o You have added fwknopd.in, but don't seem to use or install it. Plus, >> shouldn't you preprocess it instead of hardcoding the installation >> paths? > > I understood that the fwknopd.in file would be copied to the > auto-startup rc.d directory as part of bsd.port.mk? I certainly > appears to do that. I will certainly modify the .in file to preprocess > the fwknop.in file, But I would appreciate it if you could perhaps > just give me an understanding, if my assumption is incorrect, or it > should be installed explicitly. Sorry, I did not notice you set USE_RC_SUBR there, so yes, it is installed. However, according to [1] you should indeed not hardcode paths and use SUB_LIST expansions instead. [1] http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html > o IIRC ports normally do not install info/dir, as it can cause > conflicts. > > I am sorry, was unaware, I used ports-mgmt/genplist to generate the > plist and it added the info/dir as well as the libfko.info lines into > the plist. I have modified the shar file, to rectify the issues you > mentioned. Should I submit a PR again with the updated shar file? Yes, please. Don't forget to CC both bug-followup@FreeBSD.org and me in your PR reply, otherwise either I won't notice the update or it won't be registered in the PR page. ------=_Part_11_25861043.1351060888249 Content-Type: text/plain; name=fwknop.shar.txt Content-Disposition: attachment; filename=fwknop.shar.txt Content-Transfer-Encoding: base64 IyBUaGlzIGlzIGEgc2hlbGwgYXJjaGl2ZS4gIFNhdmUgaXQgaW4gYSBmaWxlLCByZW1vdmUgYW55 dGhpbmcgYmVmb3JlCiMgdGhpcyBsaW5lLCBhbmQgdGhlbiB1bnBhY2sgaXQgYnkgZW50ZXJpbmcg InNoIGZpbGUiLiAgTm90ZSwgaXQgbWF5CiMgY3JlYXRlIGRpcmVjdG9yaWVzOyBmaWxlcyBhbmQg ZGlyZWN0b3JpZXMgd2lsbCBiZSBvd25lZCBieSB5b3UgYW5kCiMgaGF2ZSBkZWZhdWx0IHBlcm1p c3Npb25zLgojCiMgVGhpcyBhcmNoaXZlIGNvbnRhaW5zOgojCiMJZndrbm9wCiMJZndrbm9wL01h a2VmaWxlCiMJZndrbm9wL3BrZy1kZXNjcgojCWZ3a25vcC9maWxlcwojCWZ3a25vcC9maWxlcy9m d2tub3BkLmluCiMJZndrbm9wL2Rpc3RpbmZvCiMJZndrbm9wL3BrZy1wbGlzdAojCmVjaG8gYyAt IGZ3a25vcApta2RpciAtcCBmd2tub3AgPiAvZGV2L251bGwgMj4mMQplY2hvIHggLSBmd2tub3Av TWFrZWZpbGUKc2VkICdzL15YLy8nID5md2tub3AvTWFrZWZpbGUgPDwgJzMyYjEyYjY3ZWIwZTI2 YWQ3OTZiMTVhOTI3OTNkZTlhJwpYIyBOZXcgcG9ydHMgY29sbGVjdGlvbiBtYWtlZmlsZSBmb3I6 CWZ3a25vcApYIwpYIyBEYXRlIGNyZWF0ZWQ6CQkJCTIzIE5vdiAyMDA3ClgjIFdob206CQkJCQlT ZWFuIEdyZXZlbjxzZWFuLmdyZXZlbkBnbWFpbC5jb20+ClgjClgjICRGcmVlQlNEOiBwb3J0cy9z ZWN1cml0eS9md2tub3AvTWFrZWZpbGUsdiAxLjYgMjAxMi8wNy8yNSAxMToyNDowOSBjcyBFeHAg JApYIwpYClhQT1JUTkFNRT0JZndrbm9wClhQT1JUVkVSU0lPTj0JMi4wLjMKWFBPUlRSRVZJU0lP Tj0JMgpYQ0FURUdPUklFUz0Jc2VjdXJpdHkKWE1BU1RFUl9TSVRFUz0JaHR0cDovL3d3dy5jaXBo ZXJkeW5lLm9yZy9md2tub3AvZG93bmxvYWQvClgKWE1BSU5UQUlORVI9CXNlYW4uZ3JldmVuQGdt YWlsLmNvbQpYQ09NTUVOVD0JU1BBIGltcGxlbWVudGF0aW9uIGZvciBMaW51eCBhbmQgRnJlZUJT RApYClhPUFRJT05TX0RFRklORT0gIEdQR01FClhPUFRJT05TX0RFRkFVTFQ9IEdQR01FClhHUEdN RV9ERVNDPQlCdWlsZCBzdXBwb3J0IGZvciBncGdtZQpYTUFOOD0JCWZ3a25vcC44IGZ3a25vcGQu OApYSU5GTz0JCWxpYmZrbwpYTUFOQ09NUFJFU1NFRD0Jbm8KWEdOVV9DT05GSUdVUkU9ICB5ZXMK WFVTRV9SQ19TVUJSPQlmd2tub3BkClgKWC5pbmNsdWRlIDxic2QucG9ydC5vcHRpb25zLm1rPgpY ClguaWYgJHtQT1JUX09QVElPTlM6TUdQR01FfQpYQlVJTERfREVQRU5EUys9CWdwZ21lOiR7UE9S VFNESVJ9L3NlY3VyaXR5L2dwZ21lClguZW5kaWYKWApYLmluY2x1ZGUgPGJzZC5wb3J0Lm1rPgoz MmIxMmI2N2ViMGUyNmFkNzk2YjE1YTkyNzkzZGU5YQplY2hvIHggLSBmd2tub3AvcGtnLWRlc2Ny CnNlZCAncy9eWC8vJyA+Zndrbm9wL3BrZy1kZXNjciA8PCAnMTM5NjQwMDlmZWFjMGFkMDgyNTFj MTQ1MmQ0MDJhNDQnClhmd2tub3AsIkZpcmVXYWxsIEtOb2NrIE9QZXJhdG9yIiwgaW1wbGVtZW50 cyBTaW5nbGUgUGFja2V0IEF1dGhvcml6YXRpb24gKFNQQSkuIApYV1dXOiBodHRwOi8vd3d3LmNp cGhlcmR5bmUub3JnL2Z3a25vcC8KMTM5NjQwMDlmZWFjMGFkMDgyNTFjMTQ1MmQ0MDJhNDQKZWNo byBjIC0gZndrbm9wL2ZpbGVzCm1rZGlyIC1wIGZ3a25vcC9maWxlcyA+IC9kZXYvbnVsbCAyPiYx CmVjaG8geCAtIGZ3a25vcC9maWxlcy9md2tub3BkLmluCnNlZCAncy9eWC8vJyA+Zndrbm9wL2Zp bGVzL2Z3a25vcGQuaW4gPDwgJ2JkODNiNWEyMTEwYzVhZTFmOWU3ZmEzOGMwZDg1NWZlJwpYIyEv YmluL3NoClgjClgjICRGcmVlQlNEOiBwb3J0cy9zZWN1cml0eS9md2tub3AKWCMKWCMgUFJPVklE RTogZndrbm9wZApYIyBSRVFVSVJFOiBMT0dJTgpYClgjClgjIEFkZCB0aGUgZm9sbG93aW5nIGxp bmVzIHRvIC9ldGMvcmMuY29uZiB0byBlbmFibGUgZndrbm9wZDoKWCMKWCNmd2tub3BkX2VuYWJs ZT0iWUVTIgpYIwpYIyBTZWUgZndrbm9wZCg4KSBmb3IgZmxhZ3MKWCMKWApYLiAvZXRjL3JjLnN1 YnIKWApYbmFtZT1md2tub3BkClhyY3Zhcj1md2tub3BkX2VuYWJsZQpYClhjb21tYW5kPSUlUFJF RklYJSUvc2Jpbi9md2tub3BkClhyZXF1aXJlZF9maWxlcz0lJVBSRUZJWCUlL2V0Yy9md2tub3Av YWNjZXNzLmNvbmYKWApYc3RhcnRfcHJlY21kPXN0YXJ0X3ByZWNtZApYc3RvcF9wb3N0Y21kPXN0 b3BfcG9zdGNtZApYClhleHRyYV9jb21tYW5kcz0icmVsb2FkIgpYClhzdGFydF9wcmVjbWQoKQpY ewpYfQpYClhzdG9wX3Bvc3RjbWQoKQpYewpYfQpYClgjIHJlYWQgc2V0dGluZ3MsIHNldCBkZWZh dWx0IHZhbHVlcwpYbG9hZF9yY19jb25maWcgJG5hbWUKWDogJHtmd2tub3BkX2VuYWJsZT0iTk8i fQpYClhydW5fcmNfY29tbWFuZCAiJDEiCmJkODNiNWEyMTEwYzVhZTFmOWU3ZmEzOGMwZDg1NWZl CmVjaG8geCAtIGZ3a25vcC9kaXN0aW5mbwpzZWQgJ3MvXlgvLycgPmZ3a25vcC9kaXN0aW5mbyA8 PCAnYmY2OTA3ZmFhMGExZGFlODc1NDBiYjYxM2NmYzBkNjYnClhTSEEyNTYgKGZ3a25vcC0yLjAu My50YXIuZ3opID0gZjdmMzA2YTY2YzY0MTAyMGU3YzdhODIwZWFhMzc0M2UyNzAwZGRlZTZlMjZj Y2EzNzQ0MGRiOTVkZjU2Yjk4NgpYU0laRSAoZndrbm9wLTIuMC4zLnRhci5neikgPSA5MDQ3NjkK YmY2OTA3ZmFhMGExZGFlODc1NDBiYjYxM2NmYzBkNjYKZWNobyB4IC0gZndrbm9wL3BrZy1wbGlz dApzZWQgJ3MvXlgvLycgPmZ3a25vcC9wa2ctcGxpc3QgPDwgJ2I4OTlhMjk5MmUzY2ZlN2RkZjIw ZjYzNjhlOGRkZmM2JwpYYmluL2Z3a25vcApYJSVFVENESVIlJS9hY2Nlc3MuY29uZgpYJSVFVENE SVIlJS9md2tub3BkLmNvbmYKWGluY2x1ZGUvZmtvLmgKWGxpYi9saWJma28uYQpYbGliL2xpYmZr by5sYQpYbGliL2xpYmZrby5zbwpYbGliL2xpYmZrby5zby4wClhzYmluL2Z3a25vcGQKWEBkaXJy bSAlJUVUQ0RJUiUlCmI4OTlhMjk5MmUzY2ZlN2RkZjIwZjYzNjhlOGRkZmM2CmV4aXQKCg== ------=_Part_11_25861043.1351060888249--