From owner-freebsd-bugs@FreeBSD.ORG  Sun Apr 20 02:20:16 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8919F37B401
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 20 Apr 2003 02:20:16 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2F94A43FDD
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 20 Apr 2003 02:20:16 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h3K9KFUp013784
	for <freebsd-bugs@freefall.freebsd.org>;
	Sun, 20 Apr 2003 02:20:15 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h3K9KFLp013783;
	Sun, 20 Apr 2003 02:20:15 -0700 (PDT)
Date: Sun, 20 Apr 2003 02:20:15 -0700 (PDT)
Message-Id: <200304200920.h3K9KFLp013783@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Peter van Dijk <peter@dataloss.nl>
Subject: Re: bin/51151: du hardlinkmatching is slow - fix included
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Peter van Dijk <peter@dataloss.nl>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Apr 2003 09:20:16 -0000

The following reply was made to PR bin/51151; it has been noted by GNATS.

From: Peter van Dijk <peter@dataloss.nl>
To: David Schultz <das@FreeBSD.ORG>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/51151: du hardlinkmatching is slow - fix included
Date: Sun, 20 Apr 2003 11:18:35 +0200

 On Sun, Apr 20, 2003 at 01:27:24AM -0700, David Schultz wrote:
 > A hash table would be more appropriate here.  You could even
 > preserve the original behavior of making infrequent calls to
 > malloc() and most of the original code by using open addressing.
 
 Yup, I'd prefer a hash too, but libc doesn't provide a suitable one,
 so I figured giving this a shot was a viable option :)
 
 > In any case, pulling in another library is probably not desirable.
 
 I feared as much.
 
 > If you would like to revise this patch, I would be happy to help
 > you get it committed.  You might also want to take a look at
 > style(9).
 
 I indeed care about this patch (or at least, a patch that speeds up
 du) getting committed.
 
 I glanced over style(9) before I submitted the patch - any specific
 nits with the current patch, regarding style?
 
 [resent with gnats in Cc:]
 
 Greetz, Peter
 -- 
 peter@dataloss.nl | ~ we care a lot: about the war we're fighting
 www.dataloss.nl   |  - gee that looks like fun! (Faith no more)
 UnderNet/#clue    | 
                   |       iraqbodycount.net: min 1878, max 2325