From owner-cvs-all Sat Mar 18 22: 3:40 2000 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 9B18437B634; Sat, 18 Mar 2000 22:03:34 -0800 (PST) (envelope-from robert@cyrus.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.9.3/8.9.3) with SMTP id BAA04692; Sun, 19 Mar 2000 01:03:24 -0500 (EST) (envelope-from robert@cyrus.watson.org) Date: Sun, 19 Mar 2000 01:03:24 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org Reply-To: Robert Watson To: Warner Losh Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bpf.c bpf.h In-Reply-To: <200003190551.WAA05331@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 18 Mar 2000, Warner Losh wrote: > In message <200003190542.VAA29960@freefall.freebsd.org> Robert Watson writes: > : favorite pccard ethernet card, and then eject the card. As some pccard > : drivers do not invoke if_detach(ifp), this bug will not manifest itself > : for those drivers. > > Which ones don't? ep, ed, and sn certainly do and I've *NEVER* seen > any bpf related crashes. I think that I would have since I run dhcp. > > Not that this isn't a good change, I just don't understand this > statement. Warner, I just successfully reproduced the bug using if_ep -- I inserted the card, ran tcpdump -ni ep0, and then ejected the card. It took a second or two, but then the system hung. if_wi seems to result in a failure much more reliably. As this bug can involve memory tromping, it will not necessarily result in an immediate page fault, although that does appear to be the case with if_wi. My statement about if_detach not being invoked by all drivers may have been a result of an incorrect reading if if_ep_pccard. If also appears to call if_detach, and also crash. :-) I have no other pccard ethernet cards, so can't test any further drivers. Given that I can reproduce the crash with if_ep, I think I'll go ahead and commit the fix to that one also, once I've had a chance to test it. Robert N M Watson robert@fledge.watson.org http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message