From owner-cvs-all  Thu Jan 11  8:21:16 2001
Delivered-To: cvs-all@freebsd.org
Received: from gatekeeper.orem.verio.net (gatekeeper.orem.verio.net [192.41.0.8])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5788337B404; Thu, 11 Jan 2001 08:20:55 -0800 (PST)
Received: from proxy.dmz.orem.verio.net (proxy.dmz.orem.verio.net [10.1.1.11])
	by gatekeeper.orem.verio.net (Postfix) with ESMTP
	id 1C5903BF11E; Thu, 11 Jan 2001 09:20:54 -0700 (MST)
Received: from ophelia.nectar.com (unknown [10.2.128.200])
	by proxy.dmz.orem.verio.net (Postfix) with ESMTP
	id DFD907C006; Thu, 11 Jan 2001 09:20:53 -0700 (MST)
Received: (from nectar@localhost)
	by ophelia.nectar.com (8.11.1/8.11.1) id f0BGKqS43794;
	Thu, 11 Jan 2001 09:20:52 -0700 (MST)
	(envelope-from nectar)
Date: Thu, 11 Jan 2001 09:20:52 -0700
From: "Jacques A. Vidrine" <n@nectar.com>
To: Daniel Eischen <eischen@vigrid.com>
Cc: "Justin T. Gibbs" <gibbs@scsiguy.com>,
	John Baldwin <jhb@FreeBSD.org>,
	=?iso-8859-1?Q?G=E9rard_Roudier?= <groudier@club-internet.fr>,
	Jake Burkholder <jake@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, Bruce Evans <bde@zeta.org.au>
Subject: Re: cvs commit: src/sys/alpha/alpha interrupt.c machdep.c mp_mac
Message-ID: <20010111092052.A43267@ophelia.nectar.com>
Mail-Followup-To: "Jacques A. Vidrine" <n@nectar.com>,
	Daniel Eischen <eischen@vigrid.com>,
	"Justin T. Gibbs" <gibbs@scsiguy.com>,
	John Baldwin <jhb@FreeBSD.org>,
	=?iso-8859-1?Q?G=E9rard_Roudier?= <groudier@club-internet.fr>,
	Jake Burkholder <jake@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, Bruce Evans <bde@zeta.org.au>
References: <200101110428.f0B4Rcs23445@aslan.scsiguy.com> <Pine.SUN.3.91.1010111000241.27724A-100000@pcnet1.pcnet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <Pine.SUN.3.91.1010111000241.27724A-100000@pcnet1.pcnet.com>; from eischen@vigrid.com on Thu, Jan 11, 2001 at 12:12:07AM -0500
X-Url: http://www.nectar.com/
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Thu, Jan 11, 2001 at 12:12:07AM -0500, Daniel Eischen wrote:
> Uh-oh.  I've just gone through libc (not committed yet) and replaced all 
> instances of "errno = x" to _set_errno(x) to deal with threaded apps.  I
> didn't realize that it actually worked correctly.
> 
> Should I discard these changes, or is _set_errno(x) seen as a better
> interface than errno = x?

I thought you were kidding until I read on a little further.

I think this is a bad idea:
  . it doesn't solve any problems
  . it breaks a well-defined API
  . we still like to share parts of libc where possible and this 
    gets in the way
  . it's damn ugly :-)

Cheers,
-- 
Jacques Vidrine / n@nectar.com / jvidrine@verio.net / nectar@FreeBSD.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message