Date: Mon, 21 Jan 2013 17:44:01 +0200 From: Jaakko Heinonen <jh@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: "Justin T. Gibbs" <gibbs@FreeBSD.org>, satan@ukr.net, Gleb Smirnoff <glebius@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: Re: panic after r244584 Message-ID: <20130121154400.GA1808@a91-153-116-96.elisa-laajakaista.fi> In-Reply-To: <20130119082739.GA1956@a91-153-116-96.elisa-laajakaista.fi> References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> <50F94D80.7000809@FreeBSD.org> <20130119082739.GA1956@a91-153-116-96.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-01-19, Jaakko Heinonen wrote: > On 2013-01-18, Alexander Motin wrote: > > At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are > > impossible there, as previous name components are unique. Special > > characters haven't yet seen, but I think theoretically possible. > > I see two possible solutions for the problem. > > 1) Replace non-printable, space and '/' characters for example with '_'. > '/' should be replaced anyway. > > 2) Apply the patches in > http://lists.freebsd.org/pipermail/svn-src-all/2013-January/063661.html > to allow spaces again. I haven't committed the patches because I > think that there isn't full consensus that it's right thing to do and > also I personally prefer not to have spaces in device names. Here's a patch to implement 1: http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130121154400.GA1808>