From owner-cvs-all  Tue Sep  4  9:41: 2 2001
Delivered-To: cvs-all@freebsd.org
Received: from mail.wrs.com (unknown-1-11.windriver.com [147.11.1.11])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4834537B406; Tue,  4 Sep 2001 09:40:54 -0700 (PDT)
Received: from laptop.baldwin.cx (john@[147.11.46.201])
	by mail.wrs.com (8.9.3/8.9.1) with ESMTP id JAA24432;
	Tue, 4 Sep 2001 09:40:49 -0700 (PDT)
Message-ID: <XFMail.010904094046.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20010904055510.050A4380C@overcee.netplex.com.au>
Date: Tue, 04 Sep 2001 09:40:46 -0700 (PDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Wemm <peter@wemm.org>
Subject: Re: cvs commit: src/sys/kern kern_shutdown.c
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On 04-Sep-01 Peter Wemm wrote:
> John Baldwin wrote:
>> 
>> On 02-Sep-01 Peter Wemm wrote:
>> > peter       2001/09/02 05:24:38 PDT
>> > 
>> >   Modified files:
>> >     sys/kern             kern_shutdown.c 
>> >   Log:
>> >   The !RESTARTABLE_PANICS code has some loose ends.
>> 
>> What is holding_giant for?  Oh, and you do know that you are truly evil
>> incarnate now, right?
> 
> I'm not sure.  Matt added it in rev 1.107, but the code that sets it is
>#if 0'ed out.  It is a real mess.

Except the code to release it isn't #if 0'd out.

> The other part of the diff was an accident that leaked from a local change.
> I've been meaning to back it out but just couldn't quite do it.  Ian Dowse
> flagged it yesterday evening I think.  I am amused at how few people had
> noticed it, and of those most had read the diff.

Heh.  We could leave it on in -current for all I care, except that it does
make all the useful messages scroll off the screen during a panic. :)

              \\|/ ____ \\|/
              \"@'/ .. \\`@\
              /_| \\__/ |_\\
                 \\__U_/

Oh, and you forgot the

Obtained from:  Linux

in the commit log. :-P

> Cheers,
> -Peter

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message