From owner-freebsd-bugs@FreeBSD.ORG  Wed Jul 12 05:10:20 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F39C516A4DA
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 12 Jul 2006 05:10:19 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B47C443D46
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 12 Jul 2006 05:10:19 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k6C5AJHr041451
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 12 Jul 2006 05:10:19 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k6C5AJHY041447;
	Wed, 12 Jul 2006 05:10:19 GMT (envelope-from gnats)
Date: Wed, 12 Jul 2006 05:10:19 GMT
Message-Id: <200607120510.k6C5AJHY041447@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Craig Rodrigues <rodrigc@crodrigues.org>
Cc: 
Subject: Re: kern/100046: [patch] mutex lock errors in drivers
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Craig Rodrigues <rodrigc@crodrigues.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jul 2006 05:10:20 -0000

The following reply was made to PR kern/100046; it has been noted by GNATS.

From: Craig Rodrigues <rodrigc@crodrigues.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: kern/100046: [patch] mutex lock errors in drivers
Date: Wed, 12 Jul 2006 01:09:18 -0400

 Here is the actual patch missing from the PR.
 
 
 Index: aac_cam.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/dev/aac/aac_cam.c,v
 retrieving revision 1.22
 diff -u -u -r1.22 aac_cam.c
 --- aac_cam.c	8 Oct 2005 15:55:09 -0000	1.22
 +++ aac_cam.c	12 Jul 2006 05:06:23 -0000
 @@ -414,6 +414,7 @@
  		} else {
  			ccb->ccb_h.status = CAM_REQ_CMP;
  			xpt_done(ccb);
 +			mtx_unlock(&sc->aac_io_lock);
  			return;
  		}
  	default:
 Index: scsi_cd.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/cam/scsi/scsi_cd.c,v
 retrieving revision 1.95
 diff -u -u -r1.95 scsi_cd.c
 --- scsi_cd.c	17 Apr 2006 09:12:53 -0000	1.95
 +++ scsi_cd.c	12 Jul 2006 05:07:23 -0000
 @@ -591,6 +591,7 @@
  
  	if (softc->sysctl_tree == NULL) {
  		printf("cdsysctlinit: unable to allocate sysctl tree\n");
 +		mtx_unlock(&Giant);
  		return;
  	}
  
 Index: scsi_da.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v
 retrieving revision 1.190
 diff -u -u -r1.190 scsi_da.c
 --- scsi_da.c	18 Apr 2006 22:01:59 -0000	1.190
 +++ scsi_da.c	12 Jul 2006 05:07:23 -0000
 @@ -1001,6 +1001,7 @@
  		CTLFLAG_RD, 0, tmpstr);
  	if (softc->sysctl_tree == NULL) {
  		printf("dasysctlinit: unable to allocate sysctl tree\n");
 +		mtx_unlock(&Giant);
  		return;
  	}