From owner-freebsd-current@freebsd.org Tue Oct 13 12:09:45 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD0C6440166 for ; Tue, 13 Oct 2020 12:09:45 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C9Z9P195tz4dsl for ; Tue, 13 Oct 2020 12:09:44 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x343.google.com with SMTP id d3so21502417wma.4 for ; Tue, 13 Oct 2020 05:09:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4gECDIowWhxqYjPzjTS1jy6nII03camEIZxC4XK4tf0=; b=QgKsVBIHGO1LphL+nfmNBKd4ZUTQUuUnvkI/SbbKOY5/TA+90T3o2RpDbzQtEZUTs3 J8YSnyiiTpvqVlXhcQFJXB6MtzzKoh1UkE/5wt4EOF8iC0OgE1EIDfiDFMtzwmytn16z 5xHgW9j316975rg1bUUblDM+p2nX5Y6D53q4hOWslxrA9wpXV3MUVDrU8pX1hK0VtLP0 bGqvQ98wqQxkjETNR+Ppw20ZgOrY7ejoiipvZDIWMFz9zjqRftfHSybHZLqxLodfOCA4 axx15ucq9pjqf5UW2PyGRb5oC+wEvDzApNaSB7Nic03H03Jv3MsJ1BjQ7FBDi3PKb1as EoLA== X-Gm-Message-State: AOAM530zjhl7tSxs72IkKndYs5TRt7cxXBjfW0MYwldD3r9ccmNGZMHP uQ9V6dQm8HQqN0qgECQxzgnCNUHt5mu6O8k3l685jZZDoEU= X-Google-Smtp-Source: ABdhPJxrYHoam1qvkQ8jZ9abyq7GEMTf9wNrQ9Z3EdJTGcrMC8pEzczzXtT4po631ANT2rF4y+3bbuJVLIBenO62tAc= X-Received: by 2002:a7b:c20d:: with SMTP id x13mr16230447wmi.83.1602590982331; Tue, 13 Oct 2020 05:09:42 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:c448:0:0:0:0:0 with HTTP; Tue, 13 Oct 2020 05:09:41 -0700 (PDT) In-Reply-To: <20201013.202148.2154404302288800973.shigeru@os-hackers.jp> References: <20201013.202148.2154404302288800973.shigeru@os-hackers.jp> From: Mateusz Guzik Date: Tue, 13 Oct 2020 14:09:41 +0200 Message-ID: Subject: Re: zfs panic when 'make buildworld buildkernel' To: YAMAMOTO Shigeru Cc: freebsd-current@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4C9Z9P195tz4dsl X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.81 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.969]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; NEURAL_HAM_LONG(-0.98)[-0.976]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::343:from]; NEURAL_HAM_SHORT(-0.87)[-0.869]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-current]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2020 12:09:45 -0000 On 10/13/20, YAMAMOTO Shigeru wrote: > > Hi, > > I try to 'make buildworld buildkernel' at full ZFS environment. > But I can't finished buildworld/buildkernel without panic. > Anyone have same trouble? > > uname -a: > ``` > FreeBSD jenkins-02.current.os-hackers.jp 13.0-CURRENT FreeBSD 13.0-CURRENT > #0 r366657: Tue Oct 13 13:07:15 JST 2020 > root@jenkins-02.current.os-hackers.jp:/usr/obj/usr/src/amd64.amd64/sys/GENERIC > amd64 > ``` > > panic message: > ``` > login: panic: VERIFY(tid) failed > > cpuid = 2 > time = 1602582381 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfffffe002abaa9f0 > vpanic() at vpanic+0x182/frame 0xfffffe002abaaa40 > spl_panic() at spl_panic+0x3a/frame 0xfffffe002abaaaa0 > taskq_dispatch() at taskq_dispatch+0xe8/frame 0xfffffe002abaaae0 > arc_prune_async() at arc_prune_async+0x3f/frame 0xfffffe002abaab00 > arc_evict_cb() at arc_evict_cb+0x1f6/frame 0xfffffe002abaab60 > zthr_procedure() at zthr_procedure+0x8f/frame 0xfffffe002abaabb0 > fork_exit() at fork_exit+0x80/frame 0xfffffe002abaabf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe002abaabf0 > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > KDB: enter: panic > [ thread pid 19 tid 100070 ] > Stopped at kdb_enter+0x37: movq $0,0x10b0116(%rip) > db> > ``` > The issue is pretty apparent: taskqid_t tqid = atomic_fetchadd_int(&tqidnext, 1); this eventually wraps to 0 and then you get the crash. Probably the thing to do is ot bump it to 64 bit and 0-check on other platforms. -- Mateusz Guzik