From owner-freebsd-ports Fri Jan 5 3:37:16 2001 From owner-freebsd-ports@FreeBSD.ORG Fri Jan 5 03:37:14 2001 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.189]) by hub.freebsd.org (Postfix) with SMTP id 9596937B400 for ; Fri, 5 Jan 2001 03:37:11 -0800 (PST) Received: (qmail 24282 invoked by uid 1000); 5 Jan 2001 11:36:00 -0000 Date: Fri, 5 Jan 2001 13:36:00 +0200 From: Peter Pentchev To: Ilya Martynov Cc: freebsd-ports@freebsd.org Subject: Re: Is there any reason for FETCH_BEFORE_ARGS? Message-ID: <20010105133600.E10329@ringworld.oblivion.bg> Mail-Followup-To: Ilya Martynov , freebsd-ports@freebsd.org References: <20010105124725.D10329@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from m_ilya@agava.com on Fri, Jan 05, 2001 at 02:29:58PM +0300 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Fri, Jan 05, 2001 at 02:29:58PM +0300, Ilya Martynov wrote: > PP> [..skip..] > PP> > PP> > Except one port news/dnews all others actually doesn't need > PP> > FETCH_BEFORE_ARGS (according man page of fetch). And I'm not sure if it is > PP> > needed even for news/dnews. Maybe just remove FETCH_BEFORE_ARGS from ports > PP> > Makefiles? > PP> > PP> I've asked this question before, the answer was that FETCH_BEFORE_ARGS > PP> is still needed for 3.x's fetch(1). The fact is, all ports which > PP> specify FETCH_BEFORE_ARGS should make this conditional on FreeBSD's > PP> version. > PP> > PP> In your specific case, just put FETCH_BEFORE_ARGS='' on make's cmdline; > PP> the Makefile overrides /etc/make.conf settings, so you can't just stick > PP> it there :( > > Moreover some Makefiles has FETCH_BEFORE_ARGS+= instead FETCH_BEFORE_ARGS= > so it is not possible to overide this settings at all :( > > After some thinking I've came up with such question: is it correct to use > FETCH_BEFORE_ARGS at all? For example I have two URLs in > MASTER_SITE_OVERRIDE in my make.conf. fetch(1) will first try to download > files from there. Even if I have old version of fetch(1) it will not need > (probably) -t or -b switches with these URLs. Switches specified in > FETCH_BEFORE_ARGS should be actually set individually for each URL in port > Makefile (if they are needed). Hmm this is an interesting idea.. something along the lines of.. FETCH_BEFORE_ARGS=fetchprogram,hostname,args fetchprogram,hostname,args ... e.g. FETCH_BEFORE_ARGS=fetch,http://server.needing.b/path/,-b \ fetch,server.needing.t,-t Then the do-fetch target should, for each URL, scan FETCH_BEFORE_ARGS, and use the arguments if and only if it finds a match on *both* the fetch program and the hostname (not URL) from which it's currently trying to fetch. Something to think about.. G'luck, Peter -- I had to translate this sentence into English because I could not read the original Sanskrit. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message