From owner-freebsd-scsi@FreeBSD.ORG Fri Apr 5 21:22:45 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7F4D3A21; Fri, 5 Apr 2013 21:22:45 +0000 (UTC) (envelope-from seanwbruno@gmail.com) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by mx1.freebsd.org (Postfix) with ESMTP id 55C21E48; Fri, 5 Apr 2013 21:22:45 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id kl13so2267097pab.4 for ; Fri, 05 Apr 2013 14:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:from:reply-to:to:cc:in-reply-to:references :content-type:date:message-id:mime-version:x-mailer; bh=63Xgq03DeeFS2hhahm3cnEAFuU/z9EOlEK8cmqMJlnE=; b=Wg3pW07sfG6lNk1s2uH9a/YtwIYk3jmYGHqrj5yYUL4b/Fbx/TAEHFXsdI6o4ttYA9 oRcgpNldI6K1FCUAneIBB7VhOxt+OE36f07DyDRHd/9M+JkAK+FxrwmN6Xr2xj1ydTXz HTKOYpmMWIQdSPMpbtWDtvUsTDwounNacfsWyv82E0gRhsvJrzFLx+k1/caZ7pYqu07Q xgZEMyR9sNMkkqft3fBWAU9RrxLRQJigpScuApfDTB/xM3WTG1Q1PAt8I4sysY9AnwJX sG7UdxDtSuH/OR9x5OKzyDlQgy1ByOK8H83X0uVhQoSeBMvCANvUBkR1zwMYytis1PvZ wM0w== X-Received: by 10.66.190.2 with SMTP id gm2mr17464019pac.25.1365196959321; Fri, 05 Apr 2013 14:22:39 -0700 (PDT) Received: from [10.73.160.242] (nat-dip7.cfw-a-gci.corp.yahoo.com. [209.131.62.116]) by mx.google.com with ESMTPS id of1sm2029285pbb.2.2013.04.05.14.22.37 (version=SSLv3 cipher=RC4-SHA bits=128/128); Fri, 05 Apr 2013 14:22:38 -0700 (PDT) Subject: Re: adding BBU relearn support to mfiutil From: Sean Bruno To: Mark Johnston In-Reply-To: <20130304033836.GA33631@oddish> References: <20130304033836.GA33631@oddish> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-S/UqI/W50Kx8QFyI4S2v" Date: Fri, 05 Apr 2013 14:22:36 -0700 Message-ID: <1365196956.17311.13.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2013 21:22:45 -0000 --=-S/UqI/W50Kx8QFyI4S2v Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Sun, 2013-03-03 at 22:38 -0500, Mark Johnston wrote: > Hi Everyone, >=20 > I recently needed to add a couple of features to mfiutil related to BBU > relearning. I've pasted a patch below which >=20 > 1. adds extra fields to the output of "mfiutil show battery" showing BBU > properties. This is essentially the output of >=20 > # MegaCli -AdpBbuInfo -GetBbuProperties -aLL >=20 > and consists of info about battery learning: the learn period, the > time at which the controller will start the next relearn, and the BBU > mode (which indicates whether the battery supports transparent > relearning). >=20 > 2. adds a couple of subcommands under "mfiutil bbu" which lets users set > the BBU properties which can be set by MegaCli. >=20 > 3. adds a command "mfiutil start learn" which immediately kicks off a > battery relearn. >=20 > These changes grew out of concern about the fact that the controller > write cache is set to write-through mode during a relearn period (which > usually lasts for several hours). This ended up causing some mysterious > and intermittent performance issues, so I needed a way of getting more > info about what was going on (using MegaCli isn't really an option for > several reasons). Some BBUs support transparent relearning, which > basically means that the controller write cache doesn't get turned off > during a relearn. However, LSI's default config doesn't enable it, and > now mfiutil can be used to do that (through "mfiutil bbu bbu-mode"). >=20 > I was hoping someone would be able to review the patch. If anyone's able > and willing to test it, I'd very much appreciate feedback from that. >=20 > Thanks! > -Mark Just to document for the record. Finally got around to testing this today with Mark providing updates. Looks good overall with a couple of nits that he is handling at the moment (man page and variable name collision). Sean --=-S/UqI/W50Kx8QFyI4S2v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iQEcBAABAgAGBQJRX0CcAAoJEBkJRdwI6BaHXqYH/37KVK+hCK/SzyK2BiGYK+AU iIab4boLwgzCWZr7fYtQwHfyngVwrwubC6grhAsyw6eDdodmKFosTZT1ZPEsXtyW JCUasWrpppxvo+HyaIF708ZlKHVX5V7O+yG2gx5IBM61DkXnh69D9hcn+hiqFU3I vHcvzpZi24gjxL2fH2fXro9RO3Ng0ctQlqW3dvirFtsV04por0XglvDO35hH47m6 wRWL4zNqiO2mbGg2u6ou3RtbwRZdBKJSFn4s9Fi766LX0+q/amwFAMt2hreXGr8M AoSPhvjtPVKulHwvMYamrmePjB8WbrN4YEu+F4YhnQe9abRj7ZELj8OwY9W4oi8= =Bfrb -----END PGP SIGNATURE----- --=-S/UqI/W50Kx8QFyI4S2v--