Date: Fri, 15 Feb 2008 01:46:41 +0100 From: Kris Kennaway <kris@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org>, Kip Macy <kmacy@freebsd.org> Subject: Re: PERFORCE change 135010 for review Message-ID: <47B4E0F1.6060006@FreeBSD.org> In-Reply-To: <200802141032.33861.jhb@freebsd.org> References: <200802080420.m184Kvmf077416@repoman.freebsd.org> <200802141032.33861.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > On Thursday 07 February 2008 11:20:57 pm Kip Macy wrote: >> http://perforce.freebsd.org/chv.cgi?CH=135010 >> >> Change 135010 by kmacy@kmacy:storage:toehead on 2008/02/08 04:20:17 >> >> add opt_global.h to dependencies >> >> Affected files ... >> >> .. //depot/projects/toehead/sys/modules/cxgb/tom/Makefile#3 edit >> >> Differences ... >> >> ==== //depot/projects/toehead/sys/modules/cxgb/tom/Makefile#3 (text+ko) ==== >> >> @@ -5,7 +5,8 @@ >> KMOD= tom >> SRCS= cxgb_tom.c cxgb_cpl_io.c cxgb_listen.c cxgb_tom_sysctl.c cxgb_cpl_socket.c >> SRCS+= cxgb_ddp.c cxgb_vm.c >> -SRCS+= opt_compat.h opt_inet.h opt_inet6.h opt_ipsec.h opt_mac.h opt_tcpdebug.h opt_ddb.h >> +SRCS+= opt_compat.h opt_inet.h opt_inet6.h opt_ipsec.h opt_mac.h >> +SRCS+= opt_tcpdebug.h opt_ddb.h opt_global.h >> SRCS+= device_if.h bus_if.h pci_if.h >> >> #CFLAGS+= -DDEBUG_PRINT -DDEBUG >> > > That's kind of odd. Do you have an explicit #include "opt_global.h" somewhere? > It also doesn't work :) The problem is that if you build a kernel+module with INVARIANTS+INVARIANT_SUPPORT set, then remove both options, rerun config, make depend, make all, the module is not rebuilt and fails to load. Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47B4E0F1.6060006>