Date: Mon, 17 Dec 2012 01:17:10 -0600 From: Bryan Venteicher <bryanv@freebsd.org> To: Jim Harris <jimharris@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: VirtIO in GENERIC Message-ID: <CAGaYwLchE-5dn-bH0afYDxpjEPvcrVDbnaahFg8ymkf0U%2BQqsg@mail.gmail.com> In-Reply-To: <CAJP=Hc-2vWn5UVXC%2Bq_shi4Sod1ejqz9x%2Be%2B3sg6e6q4fstvig@mail.gmail.com> References: <CAGaYwLcZGFgAOjE=7Bn5yFnheFxaq4fp7-zjedepLzuJge4ynQ@mail.gmail.com> <CAFAOGNQyOyJD=CcDvFRuww-ZY9MZ_sAnrNFsOzTVV5uQmyEbpg@mail.gmail.com> <CAJP=Hc-2vWn5UVXC%2Bq_shi4Sod1ejqz9x%2Be%2B3sg6e6q4fstvig@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 16, 2012 at 11:06 PM, Jim Harris <jimharris@freebsd.org> wrote: > > > On Sun, Dec 16, 2012 at 6:53 PM, Andrew Thompson <thompsa@freebsd.org> > wrote: >> >> On 17 December 2012 13:17, Bryan Venteicher <bryanv@freebsd.org> wrote: >> >> > There's been lots of requests to have VirtIO in GENERIC for i386 and >> > amd64. Anybody have any issues or concerns with this or the patch at >> > [1]. This also removes the kludge that was introduced in r239009. >> > >> > I've compiled LINT for i386 and amd64 so hopefully there won't be any >> > surprise breakages. >> > >> > [1] http://people.freebsd.org/~bryanv/patches/virtio.generic.patch >> >> >> It would be great to have the drivers enabled. You do not need the >> sys/conf/files changes, the common and arch files are combined. >> > > Removing the virtio files from sys/conf/files ensures these drivers can only > be specified in x86 kernel configuration files. r239009 added these lines > to sys/conf/files, but Bryan's patch does it more correctly. > > The only question I have is the GENERIC changes where "device virtio" is > added - it says it is required, but should this instead say it's required > for any of the other drivers in this section? > Yes, that wording could be improved; will update the patch in the morning. > -Jim >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGaYwLchE-5dn-bH0afYDxpjEPvcrVDbnaahFg8ymkf0U%2BQqsg>