From owner-freebsd-current@FreeBSD.ORG  Mon Mar  1 14:07:02 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B131B16A4CE
	for <current@freebsd.org>; Mon,  1 Mar 2004 14:07:02 -0800 (PST)
Received: from mailhub2.midco.net (mailhub2.midco.net [24.220.0.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 39B5F43D39
	for <current@freebsd.org>; Mon,  1 Mar 2004 14:07:02 -0800 (PST)
	(envelope-from pmes@bis.midco.net)
Received: (qmail 9100 invoked by uid 0); 1 Mar 2004 23:07:01 -0000
Received: from host-195-219-220-24.midco.net (HELO bis.midco.net)
	([24.220.219.195])          (envelope-sender <pmes@bis.midco.net>)
	by lvs-pop.midco.net (qmail-ldap-1.03) with SMTP
	for <dzerkel@columbus.rr.com>; 1 Mar 2004 23:07:01 -0000
Message-ID: <4043B404.9000304@bis.midco.net>
Date: Mon, 01 Mar 2004 16:07:00 -0600
From: Peter Schultz <pmes@bis.midco.net>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7a) Gecko/20040227
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "Danny J. Zerkel" <dzerkel@columbus.rr.com>
References: <404399A6.8080303@columbus.rr.com>
In-Reply-To: <404399A6.8080303@columbus.rr.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: current@freebsd.org
Subject: Re: Mozilla problems on current -- fix
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Mar 2004 22:07:02 -0000

Danny J. Zerkel wrote:
> Looks like John's sys/kern/kern_thread.c 1.171 broke Mozilla (and
> threading in general).  He appears to have left out a test that
> the sleeping thread is interruptable in one spot:
> 
> --- kern_thread.c.orig  Mon Mar  1 15:08:01 2004
> +++ kern_thread.c       Mon Mar  1 14:26:30 2004
> @@ -646,7 +646,8 @@
>                 } else if (TD_ON_SLEEPQ(td2) &&
>                            ((td2->td_wchan == &kg->kg_completed) ||
>                             (td2->td_wchan == &p->p_siglist &&
> -                            (ku->ku_mflags & KMF_WAITSIGEVENT)))) {
> +                            (ku->ku_mflags & KMF_WAITSIGEVENT))) &&
> +                             (td2->td_flags & TDF_SINTR)) {
>                         sleepq_abort(td2);
>                 } else {
>                         ku->ku_flags |= KUF_DOUPCALL;
> 
> This change fixes my Mozilla hangs and other panics on current.
>

Do you have ULE and ADAPTIVE_MUTEXES in your kernel conf?

Thanks,
Pete...