From owner-freebsd-ports-bugs@freebsd.org Tue Jun 7 12:35:05 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DDF5BB6EF58 for ; Tue, 7 Jun 2016 12:35:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B4D3E1E82 for ; Tue, 7 Jun 2016 12:35:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u57CZ5mE032277 for ; Tue, 7 Jun 2016 12:35:05 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209945] devel/jsoncpp: Does not build on 10.3 due to C++11 assumption on ppc64 Date: Tue, 07 Jun 2016 12:35:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: freebsd@simweb.ch X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 12:35:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209945 --- Comment #4 from Mathieu Simon --- Created attachment 171140 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D171140&action= =3Dedit Attemp to fix issues with older GCC version and C++11 enablement Hi Vladimir I think I may have something, it seems to compile on: - 10.3-amd64 (clang) -> Builds, with C++11 (expected, no regression) - 9.3-amd64 (GCC 4.2) -> Builds, without C++11 (expected, no regression) - 10.3-ppc64 (GCC 4.2) -> Builds, without C++11 (expected, now fixed) With this patch the port checks if the compiler is recent enough, not the OS type or OS version. This would have the added advantage of (quite likely) allowing DragonFly folks to compile lang/jsoncpp with C++11 support too sin= ce they ship newer GCC versions in their base and use the FreeBSD ports tree. The idea is based on what Mk/Uses/compiler.mk does and what I found in comp= iler checks such as in x11/eaglemode/Makefile.=20 I agree that this patch somewhat duplicates the efforts of compiler.mk. How= ever with this we still allow building on non-C++11 compilers as currently. The versions required for C++11 support of both clang and GCC support was b= ased on for C++11 implementation status sites of each project: - clang: http://clang.llvm.org/cxx_status.html - GCC: https://gcc.gnu.org/projects/cxx-status.html#cxx11 Looking forward to your feedback. -- Mathieu --=20 You are receiving this mail because: You are the assignee for the bug.=