From owner-cvs-all Wed Jan 27 19:32:59 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id TAA29883 for cvs-all-outgoing; Wed, 27 Jan 1999 19:32:59 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from pluto.plutotech.com (mail.plutotech.com [206.168.67.137]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA29854; Wed, 27 Jan 1999 19:32:54 -0800 (PST) (envelope-from gibbs@plutotech.com) Received: from narnia.plutotech.com (narnia.plutotech.com [206.168.67.130]) by pluto.plutotech.com (8.9.1/8.9.1) with ESMTP id UAA25969; Wed, 27 Jan 1999 20:32:52 -0700 (MST) (envelope-from gibbs@plutotech.com) Message-Id: <199901280332.UAA25969@pluto.plutotech.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Matt Dillon cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/eisa ahb.c In-reply-to: Your message of "Wed, 27 Jan 1999 17:33:03 PST." <199901280133.RAA40079@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 27 Jan 1999 20:24:30 -0700 From: "Justin T. Gibbs" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk >dillon 1999/01/27 17:33:03 PST > > Modified files: > sys/i386/eisa ahb.c > Log: > Fix parenthesization, but the code still looks wrong. > > Revision Changes Path > 1.5 +7 -2 src/sys/i386/eisa/ahb.c There certainly was a bug there, but your commit made the driver non-functional. Why not pass your concern on to the author/maintainer of the driver instead of committing something that does not address the problem? If I had missed your checkin mail, I would never have noticed the bug especially after you cleared the compiler warning without really fixing the problem. I've committed a proper fix. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message