From owner-freebsd-current@freebsd.org Thu Jul 30 20:05:11 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C31199ACABD for ; Thu, 30 Jul 2015 20:05:11 +0000 (UTC) (envelope-from benno@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B23C29C for ; Thu, 30 Jul 2015 20:05:11 +0000 (UTC) (envelope-from benno@FreeBSD.org) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 179C420363 for ; Thu, 30 Jul 2015 16:05:10 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Thu, 30 Jul 2015 16:05:10 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=L7F070W9MuJqT5DCx4dN++SGrMA=; b=seBYg HRrxUXQv/Cr6JUPBB5RQ960ygwF2ci+Cf4nor9nhhhyvIuqX8cvukpUKgSFbAR0n 99LUduhrfcogtwDyh33avh5+dghTwp8ZxsGyU4KD4jMLf1AbCxs8yFWIPkIMET5B OKPxVHg2ed1NWVCsl8/FJpSNwu2hnX93grl0Pk= X-Sasl-enc: F2M4VjoswX/81bFxpmKAR3ecczZWHsX/2mhAIWN4I2vK 1438286709 Received: from mittlerweile.west.isilon.com (c-67-182-131-225.hsd1.wa.comcast.net [67.182.131.225]) by mail.messagingengine.com (Postfix) with ESMTPA id 4EA9DC00012; Thu, 30 Jul 2015 16:05:09 -0400 (EDT) Content-Type: multipart/mixed; boundary="Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C" Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: pmspcv panic on boot on this box From: Benno Rice In-Reply-To: <04E640B9-423C-4C30-BF90-D3DD148C930D@FreeBSD.org> Date: Thu, 30 Jul 2015 13:05:07 -0700 Cc: freebsd-current@freebsd.org Message-Id: <765D2BB8-F101-4D8C-BF1D-BB896904FB29@FreeBSD.org> References: <20150728210109.GA6424@oldtbh.lerctr.org> <04E640B9-423C-4C30-BF90-D3DD148C930D@FreeBSD.org> To: Larry Rosenman X-Mailer: Apple Mail (2.2102) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 20:05:12 -0000 --Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Can you try the attached patch and let me know if it fixes the issue? Many thanks, Benno. --Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C Content-Disposition: attachment; filename=pmspcv.diff Content-Type: application/octet-stream; name="pmspcv.diff" Content-Transfer-Encoding: 7bit Index: sys/dev/pms/freebsd/driver/common/lxutil.c =================================================================== --- sys/dev/pms/freebsd/driver/common/lxutil.c (revision 286083) +++ sys/dev/pms/freebsd/driver/common/lxutil.c (working copy) @@ -758,6 +758,7 @@ int idx; static U32 cardMap[4] = { 0, 0, 0, 0 }; u_int16_t agtiapi_dev; // PCI device ID + u_int16_t agtiapi_vendor; // PCI vendor ID AGTIAPI_PRINTK("agtiapi_ProbeCard: start\n"); if ( ! atomic_cmpset_32( &cardMap[thisCard], 0, 5 ) ) { // card already ran @@ -766,10 +767,12 @@ } else { agtiapi_dev = pci_get_device( dev ); // get PCI device ID + agtiapi_vendor = pci_get_vendor( dev ); // get PCI vendor ID for( idx = 0; idx < COUNT(ag_card_type); idx++ ) { - if( ag_card_type[idx].deviceId == agtiapi_dev ) - { // device ID match + if( ag_card_type[idx].deviceId == agtiapi_dev && + ag_card_type[idx].vendorId == agtiapi_vendor ) + { // device and vendor IDs match memset( (void *)&agCardInfoList[ thisCard ], 0, sizeof(ag_card_info_t) ); thisCardInst->cardIdIndex = idx; --Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 30, 2015, at 11:55 AM, Benno Rice wrote: >=20 > Hi Larry, >=20 > I=E2=80=99ve brought this to the attention of PMC Sierra and we=E2=80=99= re pretty sure we=E2=80=99ve worked out what the problem is. I=E2=80=99m = just waiting on their review of the fix I=E2=80=99ve suggested. >=20 > Sorry this has caused you problems. >=20 > Many apologies, > Benno. >=20 >> On Jul 28, 2015, at 2:01 PM, Larry Rosenman wrote: >>=20 >> When I upgraded an approximately 3 month old -CURRENT system to = yesterday, I=20 >> got page not present panics, after a message about pmspcv not = supporting >> my ahd(4) deviceid.=20 >>=20 >> I did NOT capture the panic, but adding >>=20 >> nodevice pmspcv >>=20 >> Allowed me to boot.=20 >>=20 >> Dmesg.boot from the WORKING system attached.=20 >>=20 >> I *CAN* work with someone if they want.=20 >>=20 >>=20 >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to = "freebsd-current-unsubscribe@freebsd.org" >=20 > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to = "freebsd-current-unsubscribe@freebsd.org" --Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C--