From owner-freebsd-acpi@FreeBSD.ORG Fri Feb 12 19:38:26 2010 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E17B810656A5 for ; Fri, 12 Feb 2010 19:38:26 +0000 (UTC) (envelope-from d.walter@0x90.at) Received: from mail.0x90.at (s2.linuxsolutions.at [83.218.160.157]) by mx1.freebsd.org (Postfix) with ESMTP id 833668FC23 for ; Fri, 12 Feb 2010 19:38:26 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mail.0x90.at (Postfix) with ESMTP id CA7A178C2A; Fri, 12 Feb 2010 21:00:21 +0100 (CET) X-Virus-Scanned: amavisd-new at 0x90.at Received: from mail.0x90.at ([127.0.0.1]) by localhost (mails.0x90.at [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8o+Hd3navNKW; Fri, 12 Feb 2010 20:59:32 +0100 (CET) Received: from [192.168.1.2] (chello213047242248.tirol.surfer.at [213.47.242.248]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.0x90.at (Postfix) with ESMTPSA id 0979E78C11; Fri, 12 Feb 2010 20:59:31 +0100 (CET) Date: Fri, 12 Feb 2010 20:37:42 +0100 (CET) From: Daniel Walter X-X-Sender: sahne@mini-beast To: Jung-uk Kim In-Reply-To: <201002121409.49779.jkim@FreeBSD.org> Message-ID: References: <201002121320.51441.jkim@FreeBSD.org> <201002121409.49779.jkim@FreeBSD.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-acpi@FreeBSD.org Subject: Re: Call for testers acpi_dell X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2010 19:38:27 -0000 On Fri, 12 Feb 2010, Jung-uk Kim wrote: > On Friday 12 February 2010 01:33 pm, Daniel Walter wrote: >> On Fri, 12 Feb 2010, Jung-uk Kim wrote: >>> On Friday 12 February 2010 12:48 pm, Daniel Walter wrote: >>>> Hi all, >>>> >>>> I've written a small kernel driver to support Dell Mini 1011 >>>> (aka Dell Mini 10v) Brightness Controll Buttons. Since I do not >>>> have any other Dell Notebooks, I'd like you to test this module >>>> on other Dell Notebooks as well. >>>> >>>> This driver is in an early stage, but future releases will also >>>> support the rfkill switch and CRT switch. >>>> >>>> Currently following features are implemented: >>>> * Increase / Decrease Brightness >>>> * Change brightness if AC is connected / disconnected >>>> >>>> TODO: >>>> * Add CRT Support >>>> * Add Sysctl to define brightness levels for eco and ac >>>> powerprofile * Add Support for RF-Kill Switch >>>> >>>> Any suggestions are welcome >>> >>> I just quickly glanced at it but I failed see anything quite >>> specific to Dell laptops except for "TODO: Add support for >>> RF-Kill Switch". acpi_video(4) should be able to do what you >>> want. Am I missing something here? >>> >>> Jung-uk Kim >> >> hi, >> >> Yes it is possible to control the brightness using acpi_video(4) >> via sysctl but there is no support for the FN-Buttons. This module >> adds the support for those buttons. > > I see. However, my point is the probe function does not seem specific > to Dell laptops. In fact, you are just checking _BCL transition, > i.e., effectively it just makes a generic acpi_video notify handler > for brightness change. > > Jung-uk Kim Oh, I've completly overlooked this one. Sorry for that, I should replace the probing with a Dell specific probing instead. Do you have any suggestions to this one ? Daniel Walter