From owner-dev-commits-ports-main@freebsd.org Tue Apr 27 05:14:17 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 480C65FEDA6; Tue, 27 Apr 2021 05:14:17 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FTqgX1SQJz3G9q; Tue, 27 Apr 2021 05:14:15 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x532.google.com with SMTP id f29so4427976pgm.8; Mon, 26 Apr 2021 22:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Vw3iY6s6Gq58ZyNN59s/WieUilp5AMFB+fwrHtMb4P0=; b=Ed4ptoI3Uj0xrMgZJ16DbJFvVcejZyr/yLtFyIjHzGu+16U4kLknoVGnIsr9dkOJbu 9KGzZKT4uYWnEOsZxq994kn+GW8zRf3LQS0hC/aHtEmhfdv6+V5GRqxaL7Z1NgPVmoZw brFViqGeD+9P6VhDjJdrgqhWsVPGXa0PutV1JgSXpRlUUqswAKEYZl78ZpQW/df1qFlt osJldw3FvwFtXfjKd7cIN+K6FYTKVyJVfDx2Jl7BGp61IEtxHAdcwAwMV76Elj2YEbad M2zZUCvZQRT28kU6/qzaEH/ILdEyBZIfjgIi/TwFYLHsBS0sjVMfyVxFIokhjnd23dqp kYIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Vw3iY6s6Gq58ZyNN59s/WieUilp5AMFB+fwrHtMb4P0=; b=SmJd2pGw20V9IUUH28fIVdDFHKXnhRx3//v0zh0ehkgfnYzyv7k257gKlnZBqHo3ls 0fHQrEheQ+dX66Q1BH1lEG4PN910TZrZM4R6C9gKHvYqGWzjk882OzVYmE68/sbfahiJ nnP/x1BWwpsmBcQOdWVQNYhw+TMNk4cyFOlRp5P56xk98x0ujusymmknxp53b4Kaeh+g tT098WSz6B/I+9QqgKFKIZxlVMU0ezK80FBKYD+DUadwSxcnTOxinXQS0Z6ukDDF0hcA xdsXHq42l2N203eQs94zUJriL4DuTSJqzbruzmmsLkldeTaQJKvAFWWI6PiVxKD96VNh mr6g== X-Gm-Message-State: AOAM530fJJFMrlp1uQ/MmSPQGSuK71HQOKzDu+GHGHcLdOLgOTGOUg5d hXM1A5ggXmZkQ9BXWpkVVlTyRpf1rQO9g+vD X-Google-Smtp-Source: ABdhPJwsjg8ZHMPMkCykCskVhrLM1ni3vae+7XYDwvW0l5GQMjlTyPsk2U63Wq9t5cOoReqK/4jv4A== X-Received: by 2002:a05:6a00:cd1:b029:27a:6bf0:849 with SMTP id b17-20020a056a000cd1b029027a6bf00849mr1659651pfv.75.1619500454176; Mon, 26 Apr 2021 22:14:14 -0700 (PDT) Received: from [2403:5800:7500:3601:6d9c:c4c1:e630:21] (2403-5800-7500-3601-6d9c-c4c1-e630-21.ip6.aussiebb.net. [2403:5800:7500:3601:6d9c:c4c1:e630:21]) by smtp.gmail.com with UTF8SMTPSA id h21sm576153pfo.211.2021.04.26.22.14.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 22:14:13 -0700 (PDT) Sender: Kubilay Kocak Message-ID: <784ee4e3-322d-3c10-7f95-fe5437115404@FreeBSD.org> Date: Tue, 27 Apr 2021 15:14:10 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Thunderbird/90.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: git: 44b57221ced8 - main - Update OpenBVE to version 1.8.0.2. Content-Language: en-US To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202104261107.13QB7wDs039231@gitrepo.freebsd.org> <79b8acd0-ea24-c5e7-82db-a6a4ab768a10@FreeBSD.org> From: Kubilay Kocak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FTqgX1SQJz3G9q X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Ed4ptoI3; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::532 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-3.20 / 15.00]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::532:from]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::532:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::532:from]; MAILMAN_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main] X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 05:14:17 -0000 On 27/04/2021 1:31 am, Alexey Dokuchaev wrote: > On Mon, Apr 26, 2021 at 09:28:42PM +1000, Kubilay Kocak wrote: >> On 26/04/2021 9:07 pm, Alexey Dokuchaev wrote: >>> ... >>> commit 44b57221ced803c65ed137d495fb787537915ee6 >>> ... >>> Update OpenBVE to version 1.8.0.2. >> >> Any chance of getting cat/port: as prefixes to ports commit titles? > > Admittedly, I find this format quite hard to read: every time I catch > an exception, have to skip the first foo/bar part to get to what goes > after, and only if it was not clear (or important to know) what is the > port it was about, go back to the beginning. Note that I did mention > the port name in the first line, but in a way that does not disrupt > the reading flow. > > I'm also worried that this is needless duplication: this information > can be inferred from the commit itself: > > $ git show --pretty="" --name-only 44b5722 | xargs dirname | sort | uniq > games/openbve > games/openbve/files > > People have asked for it because there is no path in the the subject > line with the default git email template. Wouldn't it be better to > fix this rather than keep duplicating port directory in every commit? There's value for people other than us developers, where being able to know what thing changed without needing to drill deeper or fetch diffs, is useful in various ways. The 'commit message text' is all that should be needed, and including "component:" in its title, independent of the method by which the users may see it, including not by mail or `git`; twitter, discord, some web app, freshports, whatever else, encapsulates that. > ./danfe >