From owner-cvs-all Fri Dec 4 18:06:50 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA21490 for cvs-all-outgoing; Fri, 4 Dec 1998 18:06:50 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA21484; Fri, 4 Dec 1998 18:06:40 -0800 (PST) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id MAA16348; Sat, 5 Dec 1998 12:36:00 +1030 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.1/8.9.0) id MAA06192; Sat, 5 Dec 1998 12:35:59 +1030 (CST) Message-ID: <19981205123559.O603@freebie.lemis.com> Date: Sat, 5 Dec 1998 12:35:59 +1030 From: Greg Lehey To: Warner Losh , "Jordan K. Hubbard" Cc: Steve Kargl , "Robert V. Baron" , wollman@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Requiring make depend (was: cvs commit: src/sys/sys bus.h bus_private.h conf.h devicestat.h module.h src/sys/kern bus_if.m device_if.m kern_con) References: <2140.912819552@zippy.cdrom.com> <199812050147.SAA43570@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.91.1i In-Reply-To: <199812050147.SAA43570@harmony.village.org>; from Warner Losh on Fri, Dec 04, 1998 at 06:47:20PM -0700 WWW-Home-Page: http://www.lemis.com/~grog Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Friday, 4 December 1998 at 18:47:20 -0700, Warner Losh wrote: > In message <2140.912819552@zippy.cdrom.com> "Jordan K. Hubbard" writes: > : Perhaps not, but this is very definitely now the case in 3.0. If you > : don't make depend first, the build won't even complete. > > I understand that. make depend fixes this, but it is a bug none the > less. > > I'm just saying that even in the face of make -j, the makefile that is > generated should have the proper dependencies in it to ensure that the > generated files are build prior to their use. Relying on make depend > to do this is an ugly kludge. We've had generated files for years > before the current bus stuff was added that didn't cause this > problem. I've fixed it once already... I agree with this sentiment. make depend should make dependency information, not header files. The Makefiles should have rules to make any necessary header files. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message