From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jun 26 14:50:03 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C5D3106566B for ; Tue, 26 Jun 2012 14:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5F2898FC0C for ; Tue, 26 Jun 2012 14:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5QEo3qO045814 for ; Tue, 26 Jun 2012 14:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5QEo3qf045813; Tue, 26 Jun 2012 14:50:03 GMT (envelope-from gnats) Resent-Date: Tue, 26 Jun 2012 14:50:03 GMT Resent-Message-Id: <201206261450.q5QEo3qf045813@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Luca Pizzamiglio Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E42D31065680 for ; Tue, 26 Jun 2012 14:45:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id B66E08FC1F for ; Tue, 26 Jun 2012 14:45:42 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5QEjgrd042177 for ; Tue, 26 Jun 2012 14:45:42 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q5QEjg03042151; Tue, 26 Jun 2012 14:45:42 GMT (envelope-from nobody) Message-Id: <201206261445.q5QEjg03042151@red.freebsd.org> Date: Tue, 26 Jun 2012 14:45:42 GMT From: Luca Pizzamiglio To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/169448: [MAINTAINER] Fix THREADS support on devel/gdb X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2012 14:50:03 -0000 >Number: 169448 >Category: ports >Synopsis: [MAINTAINER] Fix THREADS support on devel/gdb >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Jun 26 14:50:02 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Luca Pizzamiglio >Release: FreeBSD 8.3-STABLE >Organization: >Environment: >Description: THREADS support was wrong managed by the Makefile. That caused the support missing. A couple of syntax typo are also fixed in the gdb link management. Thanks to Andriy Gapon and Kurt Jaeger for the support! >How-To-Repeat: >Fix: Fixed on the patch. Patch attached with submission follows: diff -Nru devel/gdb.orig/Makefile devel/gdb/Makefile --- devel/gdb.orig/Makefile 2012-06-26 14:21:41.000000000 +0200 +++ devel/gdb/Makefile 2012-06-26 16:39:04.000000000 +0200 @@ -3,12 +3,12 @@ # Date created: 16 November 2010 # Whom: Steven Kreuzer # -# $FreeBSD: ports/devel/gdb/Makefile,v 1.18 2012/06/23 09:12:05 scheidell Exp $ +# $FreeBSD$ # PORTNAME= gdb PORTVERSION= 7.4.1 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= devel MASTER_SITES= ${MASTER_SITE_GNU:S,$,:gdb,} MASTER_SITE_SUBDIR=gdb/:gdb @@ -52,7 +52,7 @@ .include -.if ${PORT_OPTIONS:MGDB_LINK) +.if ${PORT_OPTIONS:MGDB_LINK} PLIST_SUB+= GDB_LINK="" .else PLIST_SUB+= GDB_LINK="@comment " @@ -90,7 +90,7 @@ post-patch: @${REINPLACE_CMD} -e 's/$$/ [GDB v${PORTVERSION} for FreeBSD]/' \ ${WRKSRC}/gdb/version.in -.if empty(PORT_OPTIONS:MTHREADS) +.if ${PORT_OPTIONS:MTHREADS} @${CP} ${FILESDIR}/fbsd-threads.c ${WRKSRC}/gdb/ .endif @${CP} ${FILESDIR}/amd64bsd-nat.h ${WRKSRC}/gdb @@ -99,11 +99,9 @@ ${INSTALL_PROGRAM} ${WRKSRC}/gdb/gdb ${PREFIX}/bin/gdb${VER} ${LN} ${PREFIX}/bin/gdb${VER} ${PREFIX}/bin/gdbtui${VER} ${INSTALL_MAN} ${WRKSRC}/gdb/gdb.1 ${MAN1PREFIX}/man/man1/gdb${VER}.1 -#.if defined(WITH_GDB_LINK) -.if ${PORT_OPTIONS:MGDB_LINK) +.if ${PORT_OPTIONS:MGDB_LINK} ${LN} -sf gdb${VER} ${PREFIX}/bin/gdb .endif -#.if defined(WITH_PYTHON) .if ${PORT_OPTIONS:MPYTHON} (cd ${WRKSRC}/gdb; ${GMAKE} install-python ) (cd ${WRKSRC}/gdb/data-directory; ${GMAKE} install-python ) >Release-Note: >Audit-Trail: >Unformatted: