From owner-cvs-all Tue Dec 4 8:18:28 2001 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 5B70C37B419; Tue, 4 Dec 2001 08:18:18 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id fB4GGqt04027; Tue, 4 Dec 2001 17:16:53 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Luigi Rizzo Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c In-Reply-To: Your message of "Mon, 03 Dec 2001 18:13:11 PST." <200112040213.fB42DBl08877@freefall.freebsd.org> Date: Tue, 04 Dec 2001 17:16:52 +0100 Message-ID: <4025.1007482612@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Are we at the point where we need a rlprintf() in the kernel which implements rate-limiting in a generic way ? In message <200112040213.fB42DBl08877@freefall.freebsd.org>, Luigi Rizzo writes : >luigi 2001/12/03 18:13:11 PST > > Modified files: (Branch: RELENG_4) > sys/kern uipc_mbuf.c > Log: > Feature-MFC: implement rate-limited message reporting when various > types of mbuf and cluster allocation fails (in -current this is > done in sys/kern/subr_mbuf.c). The current report rate is once > per second. > > This will let us remove similar messages from the various > drivers, where they are generally not rate-limited and so much > more dangerous. > > If there is demand, we can easily implement a sysctl to enable/disable > this type of logging. > > Revision Changes Path > 1.51.2.10 +26 -11 src/sys/kern/uipc_mbuf.c > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message