Date: Sat, 28 Jun 1997 06:55:49 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, wpaul@FreeBSD.ORG Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/nfs nfs_vfsops.c Message-ID: <199706272055.GAA05782@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>I was wondering how a change to nfsrv_mknod() was supposed to fix this >since I never call mknod() on the filesystem. You mentioned a label `nfsmout' and it was near my fix so I assumed that my fix was in a general function. Actually `nfsmout' is used a lot and bugs near it are probably duplicated :(. >That said, nfsrv_statfs() in the nfs_serv.c module also does things >like: > > if (v3) > nfsm_srvpostop_attr(getret, &at); > if (error) > return (0); > >Shouldn't this be: > > if (error) > return(error); > >Or am I missing something. The error code seems to be returned indirectly in nfsm_reply(), and return(0) is common after nfsm_reply(). I guess some cases like the above break this by changing `error' after invoking nfsm_reply(). Note that there is only a problem here in the v3 case. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199706272055.GAA05782>