Date: Wed, 29 Jan 2003 07:00:30 -0800 (PST) From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/47622: New Port: misc/gkrellshoot2 Message-ID: <200301291500.h0TF0Ubo089683@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/47622; it has been noted by GNATS.
From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Andrew Stuart <elitetek@tekrealm.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47622: New Port: misc/gkrellshoot2
Date: Wed, 29 Jan 2003 16:00:15 +0100
--=.kYeDZ3,clEJ+k0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Lately Andrew Stuart told:
> sed 's/^X//' >gkrellshoot2/files/patch-Makefile << 'END-of-gkrellshoot2/files/patch-Makefile'
> X--- Makefile.orig Tue Jan 28 21:30:32 2003
> X+++ Makefile Tue Jan 28 21:39:34 2003
> X@@ -1,11 +1,11 @@
> X GTK_INCLUDE = `pkg-config gtk+-2.0 --cflags`
> X GTK_LIB = `pkg-config gtk+-2.0 --libs`
> X
> X-FLAGS = -O2 -Wall -fPIC $(GTK_INCLUDE)
> X+CFLAGS+= -Wall -fPIC $(GTK_INCLUDE)
i don't see the purpose here WRT the diff below
> X LIBS = $(GTK_LIB)
> X LFLAGS = -shared
> X
> X-CC = gcc $(CFLAGS) $(FLAGS)
> X+CC ?= gcc $(CFLAGS)
don't seem good. how about this:
CC?= gcc
CC+= ${CFLAGS}
> X
> X OBJS = gkrellshoot.o
> X
> X@@ -18,13 +18,7 @@
> X gkrellshoot.o: gkrellshoot.c
> X
> X install:
> X- if [ -d /usr/local/lib/gkrellm2/plugins/ ] ; then \
> X- install -c -s -m 644 gkrellshoot.so /usr/local/lib/gkrellm2/plugins/ ; \
> X- elif [ -d /usr/lib/gkrellm2/plugins/ ] ; then \
> X- install -c -s -m 644 gkrellshoot.so /usr/lib/gkrellm2/plugins/ ; \
> X- else \
> X- install -D -c -s -m 644 gkrellshoot.so /usr/lib/gkrellm2/plugins/gkrellshoot.so ; \
> X- fi
> X+ install -c -s gkrellshoot.so ${PREFIX}/libexec/gkrellm2/plugins
> X userinstall:
> X if [ -d $(HOME)/.gkrellm2/plugins/ ] ; then \
> X install -C -s -m 644 gkrellshoot.so $(HOME)/.gkrellm2/plugins/ ; \
large hunk for a change that could be done in the port's Makefile in a
much more easy way:
do-install:
@${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.so ${PREFIX}/libexec/gkrellm2/plugins
> X@@ -33,7 +27,6 @@
> X fi
> X
> X uninstall:
> X- rm -f /usr/local/lib/gkrellm2/plugins/gkrellshoot.so
> X- rm -f /usr/lib/gkrellm2/plugins/gkrellshoot.so
> X- rm -f $(HOME)/.gkrellm2/plugins/gkrellshoot.so
> X+ rm -f ${PREFIX}/libexec/gkrellm2/plugins/gkrellshoot.so
we don't need that, do we?
> X
> X+all: gkrellshoot.so
how about (in port's Makefile):
ALL_TARGET= ${PORTNAME}.so
> sed 's/^X//' >gkrellshoot2/Makefile << 'END-of-gkrellshoot2/Makefile'
> X# New ports collection makefile for: gkrellshoot2
(-----|1|----)
> X# Date Created: 28 Jan 2003
> X# Whom: Andrew Stuart <elitetek@tekrealm.net>
> X#
> X# $FreeBSD$
> X#
> X
> XPORTNAME= gkrellshoot
(----|2|----)
uhm. why is |1| != |2|?
there already exists a port 'gkrellshoot'. how about modifying either
${PORTNAME} or ${PKGNAMESUFFIX}?
cheers
simon
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--=.kYeDZ3,clEJ+k0
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+N+yCr5S+dk6z85oRAhqBAJ9fMbE6zlp4VKOgg7+bbFf8nWtiYwCghF+S
eHRWnREiwAqJS7V1vWJjhdQ=
=4k8a
-----END PGP SIGNATURE-----
--=.kYeDZ3,clEJ+k0--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301291500.h0TF0Ubo089683>