Date: Wed, 30 May 2001 15:02:49 PDT From: Craig Leres <leres@ee.lbl.gov> To: FreeBSD-gnats-submit@freebsd.org Cc: leres@ee.lbl.gov (Craig Leres), jef@ee.lbl.gov (Jef Poskanzer) Subject: bin/27780: [PATCH] fetch(1): don't divide by zero when fetching an empty file Message-ID: <200105302202.f4UM2nj27962@hot.ee.lbl.gov>
next in thread | raw e-mail | index | archive | help
>Number: 27780 >Category: bin >Synopsis: [PATCH] fetch(1): don't divide by zero when fetching an empty file >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed May 30 15:10:01 PDT 2001 >Closed-Date: >Last-Modified: >Originator: Craig Leres >Release: FreeBSD 4.3-RELEASE i386 >Organization: Lawrence Berkeley National Laboratory >Environment: >Description: If you try to grab a zero length file, fetch(1) prints garbage for the "percent done." >How-To-Repeat: % fetch http://www-nrg.ee.lbl.gov/leres/a Receiving a (0 bytes): -2147483648% 0 bytes transferred in 0.0 seconds (0.00 Bps) >Fix: The appended context diff checks for zero length size. =================================================================== *** fetch.c 2001/05/30 21:54:09 1.1 --- fetch.c 2001/05/30 21:54:54 *************** *** 126,132 **** xs->last = now; fprintf(stderr, "\rReceiving %s", xs->name); ! if (xs->size == -1) fprintf(stderr, ": %lld bytes", xs->rcvd); else fprintf(stderr, " (%lld bytes): %d%%", xs->size, --- 126,132 ---- xs->last = now; fprintf(stderr, "\rReceiving %s", xs->name); ! if (xs->size <= 0) fprintf(stderr, ": %lld bytes", xs->rcvd); else fprintf(stderr, " (%lld bytes): %d%%", xs->size, >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105302202.f4UM2nj27962>