Date: Tue, 15 Aug 2006 14:17:35 GMT From: Roman Divacky <rdivacky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 104030 for review Message-ID: <200608151417.k7FEHZAj096310@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=104030 Change 104030 by rdivacky@rdivacky_witten on 2006/08/15 14:16:35 Remove the crit section in futex_atomic_op(). The operations should be atomic itself and using crit section blows up in a case of page fault. Pointed out by: jhb Affected files ... .. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#25 edit Differences ... ==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_futex.c#25 (text+ko) ==== @@ -448,8 +448,6 @@ #endif /* XXX: linux verifies access here and returns EFAULT */ - critical_enter(); - switch (op) { case FUTEX_OP_SET: ret = futex_xchgl(oparg, uaddr, &oldval); @@ -470,8 +468,6 @@ ret = -ENOSYS; } - critical_exit(); - if (!ret) switch (cmp) { case FUTEX_OP_CMP_EQ:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608151417.k7FEHZAj096310>