From owner-freebsd-chromium@FreeBSD.ORG  Wed Dec 26 22:12:55 2012
Return-Path: <owner-freebsd-chromium@FreeBSD.ORG>
Delivered-To: freebsd-chromium@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 55BBD12D
 for <freebsd-chromium@freebsd.org>; Wed, 26 Dec 2012 22:12:55 +0000 (UTC)
 (envelope-from geo.liaskos@gmail.com)
Received: from mail-wi0-x229.google.com (wi-in-x0229.1e100.net
 [IPv6:2a00:1450:400c:c05::229])
 by mx1.freebsd.org (Postfix) with ESMTP id DCEAD8FC0A
 for <freebsd-chromium@freebsd.org>; Wed, 26 Dec 2012 22:12:54 +0000 (UTC)
Received: by mail-wi0-f169.google.com with SMTP id hq12so4254527wib.4
 for <freebsd-chromium@freebsd.org>; Wed, 26 Dec 2012 14:12:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=zTiOitQ6SnHlJRNXmRegWKs2+Sfl/ohqf6qxSeWeopU=;
 b=DOsJXMqSBsQzxc4vHypSVUYPCqaP2izBB2gH/muvPOSFR+Xv86N7mcKDNijClUV3ei
 cAkTtB3pvDFKOm2FEyMYOXfuA3LdcR0aNEx4EqIkwi63GabHxoTROZQ51md4Y9FZbYpG
 Sy+qHApDLBTR7qrfQ92EZG/7nlUjCohrE+TMn/ThdfdwUA2/u3rnTI7rDp2WvV35nUSe
 PjF4xWpwPBj46LvC8XsXkpeaad6aDH/CFpisn4buV7MMQSUJlyIgk0F4o7pSnDUIHiu2
 M+doPipFwtzMeHPFktp/i3vagkvXn6uvT1p38EzxXk3HRH2OT5TaS2eME66dejPA04kP
 SaAg==
MIME-Version: 1.0
Received: by 10.180.88.138 with SMTP id bg10mr44143992wib.13.1356559974010;
 Wed, 26 Dec 2012 14:12:54 -0800 (PST)
Received: by 10.195.12.113 with HTTP; Wed, 26 Dec 2012 14:12:53 -0800 (PST)
In-Reply-To: <1Tns6P-000IsX-DH@internal.tormail.org>
References: <1Tns6P-000IsX-DH@internal.tormail.org>
Date: Thu, 27 Dec 2012 00:12:53 +0200
Message-ID: <CANcjpOBHzHjigiwesgzz9MFwss9hPTE133WDK7J3YRSDid_idw@mail.gmail.com>
Subject: Re: openat, O_DIRECTORY, shell_integration_linux.cc
From: George Liaskos <geo.liaskos@gmail.com>
To: Jan Beich <jbeich@tormail.org>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-chromium@freebsd.org
X-BeenThere: freebsd-chromium@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: FreeBSD-specific Chromium issues <freebsd-chromium.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-chromium>, 
 <mailto:freebsd-chromium-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-chromium>
List-Post: <mailto:freebsd-chromium@freebsd.org>
List-Help: <mailto:freebsd-chromium-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-chromium>, 
 <mailto:freebsd-chromium-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Dec 2012 22:12:55 -0000

No, this patch is already removed actually.
The next major update will include many patch cleanups, clang build
also got fixed.

https://github.com/gliaskos/freebsd-chromium/tree/beta


Regards,

On Wed, Dec 26, 2012 at 4:38 PM, Jan Beich <jbeich@tormail.org> wrote:
> Are there issues when using openat() et al. on FreeBSD 8.0 and forward?
>
> Index: www/chromium/files/patch-chrome__browser__shell_integration_linux.cc
> ===================================================================
> --- www/chromium/files/patch-chrome__browser__shell_integration_linux.cc        (revision 309498)
> +++ www/chromium/files/patch-chrome__browser__shell_integration_linux.cc        (working copy)
> @@ -4,7 +4,7 @@
>     if (!PathService::Get(chrome::DIR_USER_DESKTOP, &desktop_path))
>       return false;
>
> -+#if !defined(OS_FREEBSD)
> ++#ifdef O_DIRECTORY
>  +// BSD: Linux-specific calls like openat are used so defined out for BSD.
>     int desktop_fd = open(desktop_path.value().c_str(), O_RDONLY | O_DIRECTORY);
>     if (desktop_fd < 0)
> _______________________________________________
> freebsd-chromium@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-chromium
> To unsubscribe, send any mail to "freebsd-chromium-unsubscribe@freebsd.org"