From owner-cvs-all Sat Dec 12 11:45:47 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA21146 for cvs-all-outgoing; Sat, 12 Dec 1998 11:45:47 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA21141; Sat, 12 Dec 1998 11:45:43 -0800 (PST) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.9.1/8.9.1) id OAA05272; Sat, 12 Dec 1998 14:45:35 -0500 (EST) (envelope-from wollman) Date: Sat, 12 Dec 1998 14:45:35 -0500 (EST) From: Garrett Wollman Message-Id: <199812121945.OAA05272@khavrinen.lcs.mit.edu> To: "Justin T. Gibbs" Cc: Julian Elischer , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/usb ohci.c In-Reply-To: <199812110608.XAA03707@pluto.plutotech.com> References: <199812110602.WAA26679@freefall.freebsd.org> <199812110608.XAA03707@pluto.plutotech.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk < said: >> This fixes the symptom and not the cause. >> The right answer is to let the PCI system know that the attach failed, >> or to fail earlier (in the PCI probe). >> The attach() is a void fn() so it can't return failure.. > pci_unmap_int should also be implemented. It's called BUS_TEARDOWN_INTR(). -GAWollman -- Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same wollman@lcs.mit.edu | O Siem / The fires of freedom Opinions not those of| Dance in the burning flame MIT, LCS, CRS, or NSA| - Susan Aglukark and Chad Irschick To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message