Date: Tue, 21 Dec 2010 21:30:14 GMT From: Sofian Brabez <sbrabez@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/153131: New port: security/honggfuzz: A general-purpose fuzzer with simple, command-line interface Message-ID: <201012212130.oBLLUERQ074608@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/153131; it has been noted by GNATS. From: Sofian Brabez <sbrabez@gmail.com> To: Alexey Dokuchaev <danfe@nsu.ru> Cc: bug-followup@freebsd.org Subject: Re: ports/153131: New port: security/honggfuzz: A general-purpose fuzzer with simple, command-line interface Date: Tue, 21 Dec 2010 22:21:05 +0100 --0016e65a0dfce014010497f236df Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi, Please to accept again, this new attached file in order to respect the required variables to handle ports license framework [1] . Regards [1] http://wiki.freebsd.org/PortsLicenseInfrastructure --=20 sbz On Tue, Dec 14, 2010 at 11:55 PM, Sofian Brabez <sbrabez@gmail.com> wrote: > Hi, > > Please use the new diff ports-security-honggfuzz-0.1.shar.txt in > attachment to improve port with the danfe@ suggestions below. > > On Tue, Dec 14, 2010 at 11:04 AM, Alexey Dokuchaev <danfe@nsu.ru> wrote: >> It seems Makefile contains some excessive or bogus data: >> >> - EXAMPLESDIR is not needed, it is set by default > > Fixed > >> - Why -i "" is used in REINPLACE_CMD? =A0Also, since inplace patching ca= n >> =A0often be cryptic (like in this case), simple comment explaining what'= s >> =A0being done would be nice > > Fixed > >> - do-build: target seems to be mostly identical to default one. =A0Is >> =A0there anything wrong with it? > > The port doesn't compile without it. > >> - OK, so -i "" is there so COPYTREE_SHARE could work. =A0Why not simply >> =A0do something like ${INSTALL_DATA} ${WRKSRC}/examples/*.sh? =A0Are the= re >> =A0subdirectories inside? =A0(Also, there is no need to escape * in >> =A0Makefile since it has no special meaning in this context.) > > Yes, there are subdirectories inside and also here COPYTREE_SHARE is > executed in a subshell, so we have to escape *. > >> - For @${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin/, we >> =A0generally do no mute installation commands (contrary to mkdir/reinpla= ce) >> =A0and usually do not append trailing slash to the `bin' directory > > Fixed > >> - Superfluous blank line before .endif >> > > Fixed > > Thanks for your suggestions danfe@, it allow me to improve more and > more my work :) > > Regards > > -- > sbz > --0016e65a0dfce014010497f236df Content-Type: text/plain; charset=US-ASCII; name="ports-security-honggfuzz-0.1.shar.txt" Content-Disposition: attachment; filename="ports-security-honggfuzz-0.1.shar.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ghzatp031 IyBUaGlzIGlzIGEgc2hlbGwgYXJjaGl2ZS4gIFNhdmUgaXQgaW4gYSBmaWxlLCByZW1vdmUgYW55 dGhpbmcgYmVmb3JlCiMgdGhpcyBsaW5lLCBhbmQgdGhlbiB1bnBhY2sgaXQgYnkgZW50ZXJpbmcg InNoIGZpbGUiLiAgTm90ZSwgaXQgbWF5CiMgY3JlYXRlIGRpcmVjdG9yaWVzOyBmaWxlcyBhbmQg ZGlyZWN0b3JpZXMgd2lsbCBiZSBvd25lZCBieSB5b3UgYW5kCiMgaGF2ZSBkZWZhdWx0IHBlcm1p c3Npb25zLgojCiMgVGhpcyBhcmNoaXZlIGNvbnRhaW5zOgojCiMJaG9uZ2dmdXp6CiMJaG9uZ2dm dXp6L01ha2VmaWxlCiMJaG9uZ2dmdXp6L3BrZy1kZXNjcgojCWhvbmdnZnV6ei9wa2ctcGxpc3QK Iwlob25nZ2Z1enovZGlzdGluZm8KIwplY2hvIGMgLSBob25nZ2Z1enoKbWtkaXIgLXAgaG9uZ2dm dXp6ID4gL2Rldi9udWxsIDI+JjEKZWNobyB4IC0gaG9uZ2dmdXp6L01ha2VmaWxlCnNlZCAncy9e WC8vJyA+aG9uZ2dmdXp6L01ha2VmaWxlIDw8ICdlOTYwNTQ1OTMwYTI5YjgwYWUyMGJmMTVlZTM3 YmE0ZicKWCMgTmV3IHBvcnRzIGNvbGxlY3Rpb24gbWFrZWZpbGUgZm9yOglob25nZ2Z1enoKWCMg RGF0ZSBjcmVhdGVkOgkJMjAxMC0xMi0xMwpYIyBXaG9tOgkJCVNvZmlhbiBCcmFiZXogPHNicmFi ZXpAZ21haWwuY29tPgpYIwpYIyAkRnJlZUJTRCQKWCMKWApYUE9SVE5BTUU9CWhvbmdnZnV6egpY UE9SVFZFUlNJT049CTAuMQpYQ0FURUdPUklFUz0Jc2VjdXJpdHkKWE1BU1RFUl9TSVRFUz0JJHtN QVNURVJfU0lURV9HT09HTEVfQ09ERX0KWEVYVFJBQ1RfU1VGWD0JLnRnegpYClhNQUlOVEFJTkVS PQlzYnJhYmV6QGdtYWlsLmNvbQpYQ09NTUVOVD0JQSBnZW5lcmFsLXB1cnBvc2UgZnV6emVyIHdp dGggc2ltcGxlLCBjb21tYW5kLWxpbmUgaW50ZXJmYWNlClgKWExJQ0VOU0U9CUFTTApYTElDRU5T RV9GSUxFPQkke1dSS1NSQ30vQ09QWUlORwpYClhVU0VfR01BS0U9CXllcwpYClgjIGlucGxhY2Ug cmVwbGFjZW1lbnQgdG8gcmVtb3ZlIHJlbGF0aXZlIGJpbmFyeSBwYXRoIGluIGV4YW1wbGVzIHNj cmlwdHMKWGRvLXBhdGNoOgpYCUAke1JFSU5QTEFDRV9DTUR9IC1pICIiIC1FICJzLFwuXC4vLCwi ICR7V1JLU1JDfS9leGFtcGxlcy8qLnNoClgKWGRvLWJ1aWxkOgpYCUAoY2QgJHtXUktTUkN9OyAk e0dNQUtFfSkKWApYZG8taW5zdGFsbDoKWC5pZiAhZGVmaW5lZChOT1BPUlRFWEFNUExFUykKWAlA JHtNS0RJUn0gJHtFWEFNUExFU0RJUn0KWAlAKGNkICR7V1JLU1JDfS9leGFtcGxlcyAmJiAke0NP UFlUUkVFX1NIQVJFfSBcKiAke0VYQU1QTEVTRElSfSkKWC5lbmRpZgpYCSR7SU5TVEFMTF9QUk9H UkFNfSAke1dSS1NSQ30vJHtQT1JUTkFNRX0gJHtQUkVGSVh9L2JpbgpYClguaW5jbHVkZSA8YnNk LnBvcnQubWs+CmU5NjA1NDU5MzBhMjliODBhZTIwYmYxNWVlMzdiYTRmCmVjaG8geCAtIGhvbmdn ZnV6ei9wa2ctZGVzY3IKc2VkICdzL15YLy8nID5ob25nZ2Z1enovcGtnLWRlc2NyIDw8ICdhYmU2 ZjcxZjkxMGU1NDViZDc3ZjEyNjhmNDk1NjU5ZScKWEhvbmdnZnV6eiBpcyBhIGdlbmVyYWwtcHVy cG9zZSBmdXp6aW5nIHRvb2wuIEdpdmVuIGEgc3RhcnRpbmcgY29ycHVzIG9mIHRlc3QKWGZpbGVz LCBIb25nZnV6eiBzdXBwbGllcyBhbmQgbW9kaWZpZXMgaW5wdXQgdG8gYSB0ZXN0IHByb2dyYW0g YW5kIHV0aWxpemUgdGhlClhwdHJhY2UoKSBBUEkvUE9TSVggc2lnbmFsIGludGVyZmFjZSB0byBk ZXRlY3QgYW5kIGxvZyBjcmFzaGVzLiAKWApYV1dXOglodHRwOi8vY29kZS5nb29nbGUuY29tL3Av aG9uZ2dmdXp6LwphYmU2ZjcxZjkxMGU1NDViZDc3ZjEyNjhmNDk1NjU5ZQplY2hvIHggLSBob25n Z2Z1enovcGtnLXBsaXN0CnNlZCAncy9eWC8vJyA+aG9uZ2dmdXp6L3BrZy1wbGlzdCA8PCAnMWJh ZDhlNDhmYzRkZTQwMmNkZTEwNjUyYzI3NjNhZDcnClhAY29tbWVudCAkRnJlZUJTRCQKWGJpbi9o b25nZ2Z1enoKWCUlUE9SVEVYQU1QTEVTJSUlJUVYQU1QTEVTRElSJSUvZXh0ZXJuYWxmdXp6ZXJz L2xvd0J5dGVzSW5jcmVhc2UucHkKWCUlUE9SVEVYQU1QTEVTJSUlJUVYQU1QTEVTRElSJSUvZXh0 ZXJuYWxmdXp6ZXJzL28yMC5zaApYJSVQT1JURVhBTVBMRVMlJSUlRVhBTVBMRVNESVIlJS9pbnB1 dGZpbGVzL2JhZGNvZGUxLnR4dApYJSVQT1JURVhBTVBMRVMlJSUlRVhBTVBMRVNESVIlJS9ydW4t aG9uZ2dmdXp6LW9uLWJhZGNvZGUxLXdpdGgtZXh0ZXJuYWxmdXp6ZXIuc2gKWCUlUE9SVEVYQU1Q TEVTJSUlJUVYQU1QTEVTRElSJSUvcnVuLWhvbmdnZnV6ei1vbi1iYWRjb2RlMS5zaApYJSVQT1JU RVhBTVBMRVMlJSUlRVhBTVBMRVNESVIlJS90YXJnZXRzL01ha2VmaWxlClglJVBPUlRFWEFNUExF UyUlJSVFWEFNUExFU0RJUiUlL3RhcmdldHMvYmFkY29kZTEuYwpYJSVQT1JURVhBTVBMRVMlJUBk aXJybSAlJUVYQU1QTEVTRElSJSUvdGFyZ2V0cwpYJSVQT1JURVhBTVBMRVMlJUBkaXJybSAlJUVY QU1QTEVTRElSJSUvaW5wdXRmaWxlcwpYJSVQT1JURVhBTVBMRVMlJUBkaXJybSAlJUVYQU1QTEVT RElSJSUvZXh0ZXJuYWxmdXp6ZXJzClglJVBPUlRFWEFNUExFUyUlQGRpcnJtICUlRVhBTVBMRVNE SVIlJQoxYmFkOGU0OGZjNGRlNDAyY2RlMTA2NTJjMjc2M2FkNwplY2hvIHggLSBob25nZ2Z1enov ZGlzdGluZm8Kc2VkICdzL15YLy8nID5ob25nZ2Z1enovZGlzdGluZm8gPDwgJzYyOThlZDRjOTA0 NDkxMDVjYzhiOWQ1MmUxOThmZTI0JwpYU0hBMjU2IChob25nZ2Z1enotMC4xLnRneikgPSA1ZWFi Y2IzNGU2Mzk4OWVkNGY1NjQyZDkxMmM4NjQxY2FlMTg2MzExZDY5MzM3NDAxMDkyYjZkNTBmODA2 ZTNhClhTSVpFIChob25nZ2Z1enotMC4xLnRneikgPSAxODIyOAo2Mjk4ZWQ0YzkwNDQ5MTA1Y2M4 YjlkNTJlMTk4ZmUyNApleGl0Cgo= --0016e65a0dfce014010497f236df--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012212130.oBLLUERQ074608>