From owner-freebsd-commit  Mon Nov 13 23:30:47 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id XAA04739
          for freebsd-commit-outgoing; Mon, 13 Nov 1995 23:30:47 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id XAA04721
          for cvs-all-outgoing; Mon, 13 Nov 1995 23:30:39 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id XAA04711
          for cvs-sys-outgoing; Mon, 13 Nov 1995 23:30:35 -0800
Received: from Root.COM (implode.Root.COM [198.145.90.17])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id XAA04692
          ; Mon, 13 Nov 1995 23:30:25 -0800
Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id XAA27943; Mon, 13 Nov 1995 23:30:16 -0800
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id XAA00205; Mon, 13 Nov 1995 23:30:11 -0800
Message-Id: <199511140730.XAA00205@corbin.Root.COM>
To: Bruce Evans <bde@zeta.org.au>
cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c 
In-reply-to: Your message of "Tue, 14 Nov 95 18:22:25 +1100."
             <199511140722.SAA00861@godzilla.zeta.org.au> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Mon, 13 Nov 1995 23:30:07 -0800
Sender: owner-commit@FreeBSD.org
Precedence: bulk

>>>bde         95/11/13 21:16:38
>>>
>>>  Modified:    sys/nfs   nfs_syscalls.c
>>>  Log:
>>>  Included <sys/sysproto.h> to get central declarations for syscall args
>>>  structs and prototypes for syscalls.
>>>  
>>>  Ifdefed duplicated decentralized declarations of args structs.  It's
>>>  convenient to have this visible but they are hard to maintain.  Some
>>>  are already different from the central declarations.  4.4lite2 puts
>>>  them in comments in the function headers but I wanted to avoid the
>>>  large changes for that.
>
>>   Now that the definitions are in sysproto.h, I'd like to see them removed
>>from the .c files.
>
>I'm not sure if they should be removed as far as that.  Do you think we
>should remove the pseudo-declarations from all vnode op functions too?
>Such declarations are useful iff they are correct.  For examples of
>possibly harmful incorrect ones, see almost any readdir():

   The vnode op functions are auto-generated and not really part of the source
tree. I see syscalls as being different since the delarations are now in a
standard, centralized place.

-DG