From owner-svn-src-head@freebsd.org Fri Jan 11 18:41:48 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 726B31498567; Fri, 11 Jan 2019 18:41:48 +0000 (UTC) (envelope-from devin@shxd.cx) Received: from shxd.cx (mail.shxd.cx [64.201.244.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0F41877FC4; Fri, 11 Jan 2019 18:41:48 +0000 (UTC) (envelope-from devin@shxd.cx) Received: from [74.217.198.10] (port=58055 helo=[10.1.7.18]) by shxd.cx with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.77 (FreeBSD)) (envelope-from ) id 1gi1kS-000L2S-33; Fri, 11 Jan 2019 10:41:40 -0800 From: Devin Teske Message-Id: Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config Date: Fri, 11 Jan 2019 10:41:44 -0800 In-Reply-To: <201901111836.x0BIaGVJ022426@pdx.rh.CN85.dnsmgr.net> Cc: Devin Teske , Warner Losh , Lars Engels , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: rgrimes@freebsd.org References: <201901111836.x0BIaGVJ022426@pdx.rh.CN85.dnsmgr.net> X-Mailer: Apple Mail (2.3445.9.1) Sender: devin@shxd.cx X-Rspamd-Queue-Id: 0F41877FC4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 18:41:48 -0000 > On Jan 11, 2019, at 10:36 AM, Rodney W. Grimes = wrote: >=20 > [ Charset UTF-8 unsupported, converting... ] >> On Fri, Jan 11, 2019 at 10:10 AM Rodney W. Grimes < >> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >>=20 >>>> On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: >>>>> The style of this .sh does not match the normal style of >>>>> such things in base, especially with respect to long lines >>>>> and indentation. >>>>=20 >>>> Do we have a style guide for shell scripts in base? How should >>>> indentation look like? >>>=20 >>> Not that I can locate, but I can state that almost all >>> of the base code uses tab indenting and limited to 80 >>> column widths, independent of c, sh, make, etc. >>>=20 >>=20 >> We have a style.Makefile, style, style.mdoc and style.lua man pages. = Maybe >> it's time for style.sh, eh? >=20 > Yes please! >=20 If we can agree to be professional and collegial, ... I'll start with chapters from the Style section of my book: = https://freebsdfrau.gitbooks.io/serious-shell-programming/content/style/aw= k.html = --=20 Devin=