From owner-freebsd-ports-bugs@freebsd.org Wed Nov 9 04:31:18 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A088C35ECC for ; Wed, 9 Nov 2016 04:31:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 67D1B1A9 for ; Wed, 9 Nov 2016 04:31:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uA94VH2I014894 for ; Wed, 9 Nov 2016 04:31:18 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 213904] [maintainer] [patch] games/zdoom: Add desktop and pixmap files Date: Wed, 09 Nov 2016 04:31:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2016 04:31:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213904 --- Comment #3 from Jan Beich (mail not working) --- Comment on attachment 176787 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D176787 svn(1) diff of games/zdoom > +DESKTOP_ENTRIES=3D "ZDoom" "${COMMENT}" "${PORTNAME}" "${PORTNAME}" "Gam= e;" ${FALSE} Don't use ${FALSE} variable if the value isn't supposed to be a command (e.= g. /usr/bin/false) or sh(1) builtin. Besides, "false" isn't actually default behavior for StartupNotify: If true, it is KNOWN that the application will send a "remove" message when started with the DESKTOP_STARTUP_ID environment variable set. If false, it is KNOWN that the application does not work with startup notification at all (does not shown any window, breaks even when using StartupWMClass, etc.). If absent, a reasonable handling is up to implementations (assuming false, using StartupWMClass, etc.). (See the Startup Notification Protocol Specification for more details). https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html Also, some fields can be left empty according to Mk/bsd.port.mk: * Comment, Icon and StartupNotify may be empty strings (""). Categories may be an empty string in some cases (see below). The other fields are mandatory. * If Categories is an empty string, bsd.port.mk will try to deduce a default value using the CATEGORIES variable. If the deduction fails, you will have to set Categories manually. You should check the generated value using "make desktop-categories", and override it if necessary. which would result in DESKTOP_ENTRIES=3D "ZDoom" "" "" "${PORTNAME}" "" "" but you may want to clarify category as "Game;Shooter;" per https://standards.freedesktop.org/menu-spec/latest/apas02.html --=20 You are receiving this mail because: You are the assignee for the bug.=