From owner-cvs-all Sat Sep 5 14:00:01 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA11317 for cvs-all-outgoing; Sat, 5 Sep 1998 14:00:01 -0700 (PDT) (envelope-from owner-cvs-all) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA11262; Sat, 5 Sep 1998 13:59:52 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.9.1/8.8.5) with SMTP id VAA03368; Sat, 5 Sep 1998 21:58:19 +0100 (BST) Date: Sat, 5 Sep 1998 21:58:19 +0100 (BST) From: Doug Rabson To: Matthew Dillon cc: "Andrey A. Chernov" , John Birrell , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/gen sleep.c In-Reply-To: <199809051816.LAA22705@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sat, 5 Sep 1998, Matthew Dillon wrote: > The sleep code is totally broken in regards to its comparisons. The > argument is an unsigned int, but values are stored in time_t which is > currently a signed long. The code, as it stands, is not clean if either > time_t changes from signed to unsigned, or if time_t changes from a 32 bit > value to a 64 bit value. Since there is no harm in doing multiple > sleeps, why not just fix the code? We no tv_sec must be at least large > enough to hold INT_MAX, so: Looks fine to me. If Andrey agrees, why don't you commit this. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039