Date: Tue, 7 Jan 2003 06:11:57 -0800 From: Maxime Henrion <mux@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: Mike Barcroft <mike@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/security/mac_lomac mac_lomac.c Message-ID: <20030107141157.GC66404@elvis.mu.org> In-Reply-To: <20030108003756.I8502-100000@gamplex.bde.org> References: <20030107002755.A45957@espresso.q9media.com> <20030108003756.I8502-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > On Tue, 7 Jan 2003, Mike Barcroft wrote: > > > Maxime Henrion <mux@freebsd.org> writes: > > > Mike Barcroft wrote: > > > > Maxime Henrion <mux@FreeBSD.org> writes: > > > > > mux 2003/01/06 04:07:38 PST > > > > > > > > > > Modified files: > > > > > sys/security/mac_lomac mac_lomac.c > > > > > Log: > > > > > Fix warnings on 64bits architectures. > > > > > > > > > > Noticed by: alpha tinderbox > > > > > > > > > > Revision Changes Path > > > > > 1.7 +1 -2 src/sys/security/mac_lomac/mac_lomac.c > > > > > > > > Doesn't this just cause signed/unsigned warnings further down when > > > > buflen needs to be a size_t for comparison with sizeof()? > > > > > > No, it doesn't, we don't have warnings for signed/unsigned problems > > > enabled. > > Er, we should have these warnings further down [the time axis] when the > warnings are enabled. The kernel is already *riddled* with such warnings. This was a fix to allow the tinderbox to compile the kernel. A better fix probably involves changing struct uio so that the uio_resid field is size_t, and then change the vn_extattr_get() interface to take a size_t * instead of an int *. I'm not going to do this work right now since it's a lot more intrusive and I only wanted to get the kernel to build. Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030107141157.GC66404>