Date: Fri, 22 Oct 2004 20:11:05 -0400 From: Michael Johnson <ahze@ahze.net> To: Sean McNeil <sean@mcneil.com> Cc: freebsd-ports@freebsd.org Subject: Re: Bogus patch (was Re: avidemux2 fails to compile) Message-ID: <086661E8-2488-11D9-952F-000A958C81C6@ahze.net> In-Reply-To: <1098488823.37356.6.camel@server.mcneil.com> References: <1098487905.5676.3.camel@server.mcneil.com> <1098488823.37356.6.camel@server.mcneil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Sean! Thanks for pointing that out, I didn't even realize that was in there that patch is only used to remove windows only functions. I just submitted a patch with a fix. Cheers, Michael On Oct 22, 2004, at 7:47 PM, Sean McNeil wrote: > There appears to be a bogus patch in the ports collection for > audio/faac. Removing files/patch-gcc allows me to compile faac and > avidemux2 without problems. > > The patch is removing a prototype of an exported routine and eliminates > several pragmas. I do not know why the pragmas are removed as they > were > there for a reason plus any compiler that doesn't support them should > just ignore it. I additionally do not know why the prototype for > faacEncEncode is removed. It is required as the following information > demonstrates: > > On Fri, 2004-10-22 at 16:31, Sean McNeil wrote: >> With standard gnome2 and stuff installed under an amd64 I cannot >> compile >> avidemux2. The problem is that faac is installed and it does not have >> any prototype for faacEncEncode. >> >> if c++ -DHAVE_CONFIG_H -I. -I. -I../.. -DXTHREADS -DXUSE_MTSAFE_API >> -I/usr/local/include/atk-1.0 -I/usr/local/include/glib-2.0 >> -I/usr/local/lib/glib-2.0/include -I/usr/X11R6/include/gtk-2.0 >> -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include >> -I/usr/X11R6/include/pango-1.0 -I/usr/local/include/freetype2 >> -I/usr/local/include -DTOOLAME='"''"' -DEXLAME='"''"' >> -I/usr/local/include -I/usr/X11R6/include >> -I/usr/local/include/ffmpeg -I/usr/local/include/a52dec -I.. >> -IADM_library -I../ADM_library -D_LARGEFILE_SOURCE >> -D_FILE_OFFSET_BITS=64 -falign-loops=16 -MT audioeng_faac.o -MD -MP >> -MF ".deps/audioeng_faac.Tpo" -c -o audioeng_faac.o >> audioeng_faac.cpp; \ >> then mv -f ".deps/audioeng_faac.Tpo" ".deps/audioeng_faac.Po"; else >> rm -f ".deps/audioeng_faac.Tpo"; exit 1; fi >> audioeng_faac.cpp: In member function `virtual uint8_t >> AVDMProcessAudio_Faac::getPacket(uint8_t*, uint32_t*, uint32_t*)': >> audioeng_faac.cpp:166: error: `faacEncEncode' undeclared (first use >> this function) >> audioeng_faac.cpp:166: error: (Each undeclared identifier is reported >> only once for each function it appears in.) >> gmake[3]: *** [audioeng_faac.o] Error 1 >> gmake[3]: Leaving directory >> `/usr/ports/multimedia/avidemux2/work/avidemux-2.0.32/avidemux/ >> ADM_audiofilter' >> >> Cheers, >> Sean >>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?086661E8-2488-11D9-952F-000A958C81C6>