Date: Tue, 26 Mar 2002 21:16:53 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Akinori MUSHA <knu@iDaemons.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <3CA0C925.BB1D183E@FreeBSD.org> References: <200203250848.g2P8mlf77991@freefall.freebsd.org> <86d6xrgnm2.wl@archon.local.idaemons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Akinori MUSHA wrote: > > At Mon, 25 Mar 2002 00:48:47 -0800 (PST), > sobomax wrote: > > sobomax 2002/03/25 00:48:47 PST > > > > Modified files: > > Mk bsd.port.mk > > Log: > > - Significantly reduce overhead associated with bsd.port.mk by replacing .USE > > macro, which was invoking separate make(1) process for each of the main > > targets, with explicit make(1) targets and specifying the dependencies on > > those targets in normal Makefile way. This gives up to 4x speedup. For the > > ports relying on the old functionality (i.e. each main target in a separate > > make(1) process) provide a USE_SUBMAKE knob, which provides old behaviour; > > > > - speed-up dependency registration process by the factor of two, which > > could be a great win especially for things like GNOME and KDE with very long > > dependency chains; > > > > - clean-up internal structure of the file, so that it is easier to understand > > and extend it when necessary. > > While the performance increase is really great, I found a problem > which violates POLA where you can no longer make multiple targets in > one invocation of make(1). For example, `make clean build' does not > work as expected, and something like `make reinstall package clean' > seems to fail sometimes, although I don't know if it depends on the > port's dependencies or on the state of the ports' working directories > (cookie files). > > So, unless this is a trivial bug you just missed which can be fixed > shortly, I think you'd better back the change out for the moment > pending investigation and solution because 5.0-DP1 is coming soon and > we don't have enough time to make sure we get all the ports and > scripts happy. Thank you for the information. I'll look into the problem later today and if there is no trivial fix then tomorrow I'll backout my change temporarly until the proper sulution is worked out. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CA0C925.BB1D183E>