Date: Fri, 08 Mar 2002 03:39:32 +0000 From: Tony Finch <dot@dotat.at> To: FreeBSD-gnats-submit@freebsd.org Cc: Tony Finch <dot@dotat.at> Subject: kern/35660: puc driver broken in RELENG_4 Message-ID: <E16jBEC-0001hh-00@hand.dotat.at>
next in thread | raw e-mail | index | archive | help
>Number: 35660 >Category: kern >Synopsis: puc driver broken in RELENG_4 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Mar 07 19:40:01 PST 2002 >Closed-Date: >Last-Modified: >Originator: Tony Finch >Release: FreeBSD 4.5-STABLE-20020220 i386 >Organization: dotat labs >Environment: System: FreeBSD hand.dotat.at 4.5-STABLE-20020220 FreeBSD 4.5-STABLE-20020220 #15: Wed Feb 20 07:46:52 GMT 2002 fanf@hand.dotat.at:/FreeBSD/obj/FreeBSD/releng4/sys/SHARP i386 I'm trying to compile RELENG_4's LINT, cvsupped at Fri Mar 8 03:00:37 GMT 2002 >Description: fanf@hand.dotat.at:/FreeBSD/obj/FreeBSD/releng4/sys/LINT :; cc -c -O -pipe -march=pentium -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -nostdinc -I- -I. -I/FreeBSD/releng4/sys -I/FreeBSD/releng4/sys/../include -I/FreeBSD/releng4/sys/contrib/ipfilter -D_KERNEL -include opt_global.h -elf -fno-builtin -mpreferred-stack-boundary=2 /FreeBSD/releng4/sys/dev/puc/puc.c /FreeBSD/releng4/sys/dev/puc/puc.c: In function `puc_pci_attach': /FreeBSD/releng4/sys/dev/puc/puc.c:216: `INTR_FAST' undeclared (first use in this function) /FreeBSD/releng4/sys/dev/puc/puc.c:216: (Each undeclared identifier is reported only once /FreeBSD/releng4/sys/dev/puc/puc.c:216: for each function it appears in.) >How-To-Repeat: Build LINT. >Fix: I'm haven't a clue about the details, but INTR_FAST is defined in sys/i386/include/intr_machdep.h to be 1, but this header isn't included by puc.c. I think it's more likely that what is wanted is INTR_TYPE_FAST=128 to go with INTR_TYPE_TTY=1, and 128|1 would have slightly more effect than 1|1. Index: puc.c =================================================================== RCS file: /home/ncvs/src/sys/dev/puc/puc.c,v retrieving revision 1.3.2.1 diff -u -r1.3.2.1 puc.c --- puc.c 7 Mar 2002 17:48:57 -0000 1.3.2.1 +++ puc.c 8 Mar 2002 03:30:15 -0000 @@ -213,7 +213,7 @@ sc->irqrid = rid; #ifdef PUC_FASTINTR irq_setup = BUS_SETUP_INTR(device_get_parent(dev), dev, res, - INTR_TYPE_TTY | INTR_FAST, puc_intr, sc, &sc->intr_cookie); + INTR_TYPE_TTY | INTR_TYPE_FAST, puc_intr, sc, &sc->intr_cookie); #else irq_setup = ENXIO; #endif >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E16jBEC-0001hh-00>