From owner-svn-src-all@FreeBSD.ORG Tue Jul 22 16:39:12 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 10C479D6; Tue, 22 Jul 2014 16:39:12 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F20992A55; Tue, 22 Jul 2014 16:39:11 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s6MGdBpY077094; Tue, 22 Jul 2014 16:39:11 GMT (envelope-from pfg@svn.freebsd.org) Received: (from pfg@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s6MGdB3U077092; Tue, 22 Jul 2014 16:39:11 GMT (envelope-from pfg@svn.freebsd.org) Message-Id: <201407221639.s6MGdB3U077092@svn.freebsd.org> From: "Pedro F. Giffuni" Date: Tue, 22 Jul 2014 16:39:11 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r268985 - head/lib/libc/stdio X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2014 16:39:12 -0000 Author: pfg Date: Tue Jul 22 16:39:11 2014 New Revision: 268985 URL: http://svnweb.freebsd.org/changeset/base/268985 Log: Mostly cosmetic cleanups. In fputs() avoid implcit casting on iov.iov_len. MFC after: 3 days Modified: head/lib/libc/stdio/fputs.c head/lib/libc/stdio/puts.c Modified: head/lib/libc/stdio/fputs.c ============================================================================== --- head/lib/libc/stdio/fputs.c Tue Jul 22 16:19:01 2014 (r268984) +++ head/lib/libc/stdio/fputs.c Tue Jul 22 16:39:11 2014 (r268985) @@ -55,7 +55,7 @@ fputs(const char * __restrict s, FILE * struct __siov iov; iov.iov_base = (void *)s; - iov.iov_len = uio.uio_resid = strlen(s); + uio.uio_resid = iov.iov_len = strlen(s); uio.uio_iov = &iov; uio.uio_iovcnt = 1; FLOCKFILE(fp); Modified: head/lib/libc/stdio/puts.c ============================================================================== --- head/lib/libc/stdio/puts.c Tue Jul 22 16:19:01 2014 (r268984) +++ head/lib/libc/stdio/puts.c Tue Jul 22 16:39:11 2014 (r268985) @@ -51,12 +51,12 @@ int puts(char const *s) { int retval; - size_t c = strlen(s); + size_t c; struct __suio uio; struct __siov iov[2]; iov[0].iov_base = (void *)s; - iov[0].iov_len = c; + iov[0].iov_len = c = strlen(s); iov[1].iov_base = "\n"; iov[1].iov_len = 1; uio.uio_resid = c + 1;