From owner-cvs-all@FreeBSD.ORG Tue May 1 10:06:44 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3A15716A401; Tue, 1 May 2007 10:06:44 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-3-125.belrs4.nsw.optusnet.com.au [220.239.3.125]) by mx1.freebsd.org (Postfix) with ESMTP id B863513C44C; Tue, 1 May 2007 10:06:43 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.14.1/8.14.1) with ESMTP id l41A6gvR001348; Tue, 1 May 2007 20:06:42 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.14.1/8.14.1/Submit) id l41A6gjU001347; Tue, 1 May 2007 20:06:42 +1000 (EST) (envelope-from peter) Date: Tue, 1 May 2007 20:06:42 +1000 From: Peter Jeremy To: Andrey Chernov , Alfred Perlstein , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20070501100642.GB823@turion.vk2pj.dyndns.org> References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <20070501000242.GA19510@nagual.pp.ru> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.14 (2007-02-12) Cc: Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 10:06:44 -0000 --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2007-May-01 04:02:42 +0400, Andrey Chernov wrote: >On Mon, Apr 30, 2007 at 06:57:17PM -0400, David Schultz wrote: >> I think Alfred is absolutely right, and this is a pretty major >> POLA violation.=20 > >That's -current for. Do you suggest to wait yet more N years to commit=20 >exact that stuff? I would have expected this proposed change to get a heads-up in current@ first. _Especially_ since there is a current thread in current@ about fixing some long-standing memory leaks in our *env() functions. Implementing a major POLA violation without any warning whilst other changes to the same code are being discussed in one of the mailing lists could be seen as impolite. >There is no SVR4 bugs in this commit. The SVR4 behaviour (as documented in SUSv3) is a bug. Note that the C90 (ANSI X3.159-1989, ISO 9899:1990) does not include putenv() or setenv() due to the the lack of any concensus on how they should behave. FreeBSD does not and (AFAIK) has never claimed to be to-the-letter POSIX compliance by default. --=20 Peter Jeremy --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGNxEy/opHv/APuIcRAkWuAJ9dKg3/2gK8HFLfJ37TH7NLLef5yQCgv/8L iDGm1PtIKDBlfQyKZS5NPmE= =Ag6J -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--