From owner-freebsd-net@FreeBSD.ORG Mon Oct 15 17:27:13 2012 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9CD2BBF6; Mon, 15 Oct 2012 17:27:13 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 24B7B8FC1A; Mon, 15 Oct 2012 17:27:13 +0000 (UTC) Received: by mail-vb0-f54.google.com with SMTP id v11so7047457vbm.13 for ; Mon, 15 Oct 2012 10:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=4MNchQ5xQdhoam5MbxDbY7jC8+4pI2r+OrtoDo+4/0c=; b=wb2tnoQoG2bVaTe/QkKUArXmvc0KY+WKYdF4Glo/OAfBZx0zXSRJpizyYF7VvpklTA hnGncBqxXcvnr22r9yevNNKEa6BtcrlEmg5Fu6Kt/G9/CEWm5RQF45lz0xdYFNG/7Xe7 ykKs1XzpgvdmU8XydjGX1tcMmtmrD/esJq5YTRffnt2GhErsHVdi1rtgyUdAUvyhMWvS zS0SDd/EccH/GaTzrY9gmMoHH/+CYntyLM6FWKFO6C3Dl1tE2PXCTVBjmpQeY57oAnH+ dE3bqWLQwkM1yov3sBwEIoujg7n2mS9RMGBKD6J60lXoMIglVGFPdOJdHuo4IR3pJz3Z zXNw== MIME-Version: 1.0 Received: by 10.52.65.147 with SMTP id x19mr5858273vds.113.1350322032593; Mon, 15 Oct 2012 10:27:12 -0700 (PDT) Received: by 10.58.68.8 with HTTP; Mon, 15 Oct 2012 10:27:12 -0700 (PDT) In-Reply-To: <20121015165828.GX89655@glebius.int.ru> References: <5079A9A1.4070403@FreeBSD.org> <20121015162926.GV89655@FreeBSD.org> <20121015165828.GX89655@glebius.int.ru> Date: Mon, 15 Oct 2012 10:27:12 -0700 Message-ID: Subject: Re: ixgbe & if_igb RX ring locking From: Jack Vogel To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "Alexander V. Chernikov" , net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2012 17:27:13 -0000 On Mon, Oct 15, 2012 at 9:58 AM, Gleb Smirnoff wrote: > On Mon, Oct 15, 2012 at 09:39:24AM -0700, Jack Vogel wrote: > J> > To me this unlock/lock looks like a legacy from times, when the driver > J> > had a single mutex for both TX and RX parts. > J> > > J> > And removing this re-locking in foo_rxeof() was one of the aims for > J> > separate > J> > TX/RX locking. > J> > > J> > Really, lurking through history shows that once driver had split its > J> > locking > J> > to separate RX and TX part, these unlock/lock was removed. However, > later > J> > this unlock/lock was added back: > J> > > J> > > J> > > http://svnweb.freebsd.org/base/head/sys/dev/e1000/if_igb.c?revision=209068&view=markup > J> > > J> > , without any comments for the reason it is added back. > J> > > J> > I did not want to add it back, there were problems that constrained > me to > J> do so, although its > J> been some time, I'd be happy to do some testing again without and see. > > Can you please dig through mail archives to identify these problems? I > can't imagine any. > > It may not be in email, there were tests going on internally here that I often was working with... At this point it doesn't matter, Alexander says its running without, I will have some more testing on current code and go from there. Jack