From owner-freebsd-ports-bugs@FreeBSD.ORG  Sun Oct 21 11:30:01 2012
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 631CA2FC
 for <freebsd-ports-bugs@hub.freebsd.org>; Sun, 21 Oct 2012 11:30:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [8.8.178.135])
 by mx1.freebsd.org (Postfix) with ESMTP id 4AF868FC12
 for <freebsd-ports-bugs@hub.freebsd.org>; Sun, 21 Oct 2012 11:30:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9LBU1ig011937
 for <freebsd-ports-bugs@freefall.freebsd.org>; Sun, 21 Oct 2012 11:30:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9LBU1wp011934;
 Sun, 21 Oct 2012 11:30:01 GMT (envelope-from gnats)
Date: Sun, 21 Oct 2012 11:30:01 GMT
Message-Id: <201210211130.q9LBU1wp011934@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Subject: Re: ports/171951: update port: security/fwknop FireWall KNock OPerator
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Raphael Kubo da Costa <rakuco@FreeBSD.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Oct 2012 11:30:01 -0000

The following reply was made to PR ports/171951; it has been noted by GNATS.

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: Sean Greven <sean.greven@gmail.com>
Subject: Re: ports/171951: update port: security/fwknop FireWall KNock OPerator
Date: Sun, 21 Oct 2012 14:24:13 +0300

 A few comments about the patch:
 
  o You have added fwknopd.in, but don't seem to use or install it. Plus,
    shouldn't you preprocess it instead of hardcoding the installation
    paths?
 
  o IIRC ports normally do not install info/dir, as it can cause
    conflicts.
 
  o Instead of specifying info/libfko.info in the plist, you could use
    the INFO variable in the Makefile.