Date: Sun, 21 Oct 2012 11:30:01 GMT From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/171951: update port: security/fwknop FireWall KNock OPerator Message-ID: <201210211130.q9LBU1wp011934@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/171951; it has been noted by GNATS.
From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: Sean Greven <sean.greven@gmail.com>
Subject: Re: ports/171951: update port: security/fwknop FireWall KNock OPerator
Date: Sun, 21 Oct 2012 14:24:13 +0300
A few comments about the patch:
o You have added fwknopd.in, but don't seem to use or install it. Plus,
shouldn't you preprocess it instead of hardcoding the installation
paths?
o IIRC ports normally do not install info/dir, as it can cause
conflicts.
o Instead of specifying info/libfko.info in the plist, you could use
the INFO variable in the Makefile.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210211130.q9LBU1wp011934>