Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Oct 2014 20:54:20 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-net@FreeBSD.org
Subject:   [Bug 194453] [dummynet] pipe config bw parameter is limited to 2Gbits per second
Message-ID:  <bug-194453-2472-FmXt9sRRnc@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-194453-2472@https.bugs.freebsd.org/bugzilla/>
References:  <bug-194453-2472@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194453

Hiren Panchasara <hiren@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Triage                |In Discussion
                 CC|                            |hiren@FreeBSD.org

--- Comment #2 from Hiren Panchasara <hiren@FreeBSD.org> ---
(In reply to boba from comment #0)
> It's impossible to create "pipe" with bandwidth higher than 2Gbits per
> second. Possible due to "signed" type of variable.
> 
> # ipfw pipe 1 config bw 2700mbit/s
> ipfw: bandwidth too large

I think you are right that its overflowing because of "signed" type.

A simple change like this may fix the problem:

Index: dummynet.c
===================================================================
--- dummynet.c  (revision 270969)
+++ dummynet.c  (working copy)
@@ -546,7 +546,7 @@
                if_name[namelen] = '\0';
                *bandwidth = 0;
        } else {        /* read bandwidth value */
-               int bw;
+               uint32_t bw;
                char *end = NULL;

                bw = strtoul(arg, &end, 0);

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194453-2472-FmXt9sRRnc>