From owner-cvs-all Tue May 21 8: 5:29 2002 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 4F17B37B40B; Tue, 21 May 2002 08:04:57 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [IPv6:fec0::1:12]) by Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4LF4t7e007731; Tue, 21 May 2002 16:04:55 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4LF4plr006616; Tue, 21 May 2002 16:04:52 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200205211504.g4LF4plr006616@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: John Baldwin Cc: Brian Somers , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Makoto Matsushita Subject: Re: cvs commit: src/sys/i386/i386 userconfig.c In-Reply-To: Message from John Baldwin of "Tue, 21 May 2002 10:38:48 EDT." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 21 May 2002 16:04:51 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On 21-May-2002 Brian Somers wrote: > >> > >> jhb> Compile in the 'intro' command if VISUAL_USERCONFIG is > >> jhb> specified not just for INTRO_USERCONFIG. This allows a > >> jhb> userconfig script to use the 'intro' command to bring up the > >> jhb> introduction kernel config screen which cdboot ISO's use. > >> > >> Wonderful! > >> > >> jhb> The only downside for a cdboot ISO now is that when you boot up > >> jhb> you get bogus error messages from kldloading the drivers in the > >> jhb> mfsroot since the kernel modules are already present in GENERIC. > >> > >> I'm also same problem in my mind. Perhaps we can steal some codes > >> (or logics) from ifmaybeload() at src/usr.sbin/ifconfig/ifconfig.c. > > > > Or perhaps src/usr.sbin/ppp/defs.c:loadmodules(). > > Maybe we need a generic function in libutil then to avoid duplicating > this code. The problem is that the code would read something like: int loadmodule(const char *module) { if (modfind(module) == -1) return (kldload(module)); return (0); } A bit unnecessary really.... (I put loadmodules() into ppp because I tend to need to load more than one module, and it was more convenient that way....). > -- > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message