From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Aug 31 09:10:25 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5336025E for ; Sun, 31 Aug 2014 09:10:25 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1FAF51CA7 for ; Sun, 31 Aug 2014 09:10:25 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7V9AONr099424 for ; Sun, 31 Aug 2014 09:10:25 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193196] New: [patch][stage][new-maintainer] amanda-server and amanda-client: Stage support and take maintainership Date: Sun, 31 Aug 2014 09:10:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fbsd@dylanleigh.net X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2014 09:10:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193196 Bug ID: 193196 Summary: [patch][stage][new-maintainer] amanda-server and amanda-client: Stage support and take maintainership Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: fbsd@dylanleigh.net Created attachment 146586 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=146586&action=edit Imperfect patch to add staging support and new maintaner for amanda-server/amanda-client The attached patch adds stage support to amanda-server (and amanda-client, which is a slave port of amanda-server). It also sets me as the maintainer (was unmaintained). It builds and runs OK on my 9-STABLE AMD64 fileserver, but there are some possible stage-related issues: 1) Amanda (upstream code) builds its own install-hook target which it uses to set setuid bits amongst other things, This isn't ideal and prevents packages being built as non-root amongst other things. I have tried to fix this but haven't had the time yet to figure it out so I have set NEEDS_ROOT in the Makefile for now. 2) Many reported orphans were added to the plist after several iterations of the patch, and I am not sure if I have set everything correctly so that files which will only be present given certain OPTIONS are set correctly in the plist and vice versa. Some of the reported orphans from make check-orphans seem to be false positives caused by the way the port splits up building the client and server. This is my first staging patch, so I expect errors. Please let me know if there is anything missing. -- Dylan -- You are receiving this mail because: You are the assignee for the bug.