From owner-svn-src-head@freebsd.org Wed Nov 8 16:04:17 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D139AE57152; Wed, 8 Nov 2017 16:04:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F0A47FF40; Wed, 8 Nov 2017 16:04:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id C78E71CF5E; Wed, 8 Nov 2017 16:04:15 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id BC468274E; Wed, 8 Nov 2017 16:04:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id VxMWnRAYDioJ; Wed, 8 Nov 2017 16:04:10 +0000 (UTC) Subject: Re: svn commit: r325520 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 30DA62745 To: Renato Botelho , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201711071820.vA7IK835007755@repo.freebsd.org> <9c4e54cb-26b5-00f5-d672-5cde8b15b187@gmail.com> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Wed, 8 Nov 2017 08:04:11 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <9c4e54cb-26b5-00f5-d672-5cde8b15b187@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="g3OSGBr2clmKAD9jgb8wbVfEiQO5KoFgd" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 16:04:17 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --g3OSGBr2clmKAD9jgb8wbVfEiQO5KoFgd Content-Type: multipart/mixed; boundary="qMKKMhtvFSeFXm1gltGjD0cBKHQ3ojsW5"; protected-headers="v1" From: Bryan Drewery To: Renato Botelho , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r325520 - head/share/mk References: <201711071820.vA7IK835007755@repo.freebsd.org> <9c4e54cb-26b5-00f5-d672-5cde8b15b187@gmail.com> In-Reply-To: <9c4e54cb-26b5-00f5-d672-5cde8b15b187@gmail.com> --qMKKMhtvFSeFXm1gltGjD0cBKHQ3ojsW5 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/8/2017 7:25 AM, Renato Botelho wrote: > On 07/11/17 16:20, Bryan Drewery wrote: >> Author: bdrewery >> Date: Tue Nov 7 18:20:08 2017 >> New Revision: 325520 >> URL: https://svnweb.freebsd.org/changeset/base/325520 >> >> Log: >> Reenable AUTO_OBJ by default. >> =20 >> The problem with it was a bogus .OBJDIR in some cases where creation= of >> object directories were purposely not attempted, such as for 'make c= leandir' >> and in etc/ sub-directories. In these cases bmake would start with = a >> bogus .OBJDIR like etc/ due to MAKEOBJDIR being a dynamic value base= d on >> .CURDIR, SRCTOP, and OBJTOP. OBJTOP would not yet be defined but is= >> during early src.sys.obj.mk. That file and auto.obj.mk both were no= t >> modifying .OBJDIR unless they expected to create the objdir. Thus i= n >> these cases the .OBJDIR was left as etc/* rather than fixed to the >> proper .CURDIR. >> =20 >> The issues were fixed in r325404 and r325416. An assertion to avoid= the >> bad .OBJDIR was added in r325405. >> =20 >> Sponsored by: Dell EMC Isilon >=20 > Bryan, >=20 > Are these messages expected to show when make -s is used? >=20 > [Creating objdir /usr/obj/usr/src/amd64.amd64/usr.bin/look...] >=20 > Thanks >=20 Thanks, fixed in r325557. --=20 Regards, Bryan Drewery --qMKKMhtvFSeFXm1gltGjD0cBKHQ3ojsW5-- --g3OSGBr2clmKAD9jgb8wbVfEiQO5KoFgd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaAyr7AAoJEDXXcbtuRpfPjtMH/i5GYPBTNRQ3PmVIrNB3gsr9 /oy6Fn1d9H1KOqOX3k/SOSjznUGoRY+Bs7Q7aMe1HCPmQuofXZ/xDqGZO1p91C2D kw9xudahF+yiomLbiCrxqGhxW2o+lGQGHDjtQBKBS7cucExZte5XGl/DzgKCNXen +4fFnMelcb2U6axKt/ksP+uQ80Jhjkkjs2x3BSLDEXd6e1Tu3t7veCsBdumn0tSk +RFm4aB1j5K5hyNPeHO19qkl5HZfYvN4NZimHCGstTaTOjf2Pc8cj0mrXPNDL6uB IvHYUFBp9I8HwqGsOXnFPrmL8bGEOMIDVXMAk/B4vIM4oJJwztqiloI9X6u9/E8= =WcXo -----END PGP SIGNATURE----- --g3OSGBr2clmKAD9jgb8wbVfEiQO5KoFgd--